r113650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113649‎ | r113650 | r113651 >
Date:19:58, 12 March 2012
Author:saper
Status:ok (Comments)
Tags:
Comment:
Revert r113619, r113649: Breaks unit tests

https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/3210/console

Maybe a new property with unpredictable
value breaks some tests. Need to investigate.
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2880,7 +2880,6 @@
28812881 'user_token' => $user->mToken,
28822882 'user_registration' => $dbw->timestamp( $user->mRegistration ),
28832883 'user_editcount' => 0,
2884 - 'user_touched' => self::newTouchedTimestamp(),
28852884 );
28862885 foreach ( $params as $name => $value ) {
28872886 $fields["user_$name"] = $value;
@@ -2899,9 +2898,6 @@
29002899 */
29012900 public function addToDatabase() {
29022901 $this->load();
2903 -
2904 - $this->mTouched = self::newTouchedTimestamp();
2905 -
29062902 $dbw = wfGetDB( DB_MASTER );
29072903 $seqVal = $dbw->nextSequenceValue( 'user_user_id_seq' );
29082904 $dbw->insert( 'user',
@@ -2917,7 +2913,6 @@
29182914 'user_token' => $this->mToken,
29192915 'user_registration' => $dbw->timestamp( $this->mRegistration ),
29202916 'user_editcount' => 0,
2921 - 'user_touched' => $dbw->timestamp( $this->mTouched ),
29222917 ), __METHOD__
29232918 );
29242919 $this->mId = $dbw->insertId();

Follow-up revisions

RevisionCommit summaryAuthorDate
r113668Revert r113650 and reapply r113619 and r113649 with one modification: User::c...ialex21:17, 12 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113619Set the user_touched field directly when adding a new user to the database so...ialex13:07, 12 March 2012
r113649Fix r113619: Convert timestamp to the backend database valuesaper19:35, 12 March 2012

Comments

#Comment by IAlex (talk | contribs)   21:05, 12 March 2012

Unit tests are working correctly on my local machine with PostgreSQL as DB backend (and before applying this revision)...

#Comment by IAlex (talk | contribs)   21:26, 12 March 2012

Sorry, I had the change I wanted to commit in my working directory when testing that. Reapplied in r113668 with that change.

Status & tagging log