r113594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113593‎ | r113594 | r113595 >
Date:22:06, 11 March 2012
Author:siebrand
Status:ok (Comments)
Tags:i18nreview 
Comment:
Add definitionFile to work with export.php's ppgettext.
Modified paths:
  • /trunk/translatewiki/Mwlib/Mwlibrl.yaml (modified) (history)

Diff [purge]

Index: trunk/translatewiki/Mwlib/Mwlibrl.yaml
——@@ -10,6 +10,7 @@
1111 FILES:
1212 class: GettextFFS
1313 sourcePattern: %GROUPROOT%/mwlib.rl/mwlib/rl/locale/%CODE%/LC_MESSAGES/mwlib.rl.po
 14+ definitionFile: %GROUPROOT%/mwlib.rl/mwlib/rl/locale/en/LC_MESSAGES/mwlib.rl.po
1415 targetPattern: mwlib.rl/mwlib/rl/locale/%CODE%/LC_MESSAGES/mwlib.rl.po
1516 codeMap:
1617 pt-br: pt_BR

Follow-up revisions

RevisionCommit summaryAuthorDate
r113756Follow-up r113594: Update export.php so that when using gettext post processi...siebrand20:16, 13 March 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:46, 12 March 2012

ppgettext should be fixed.

#Comment by Siebrand (talk | contribs)   20:00, 13 March 2012

Command documentation actually states: 

  --ppgettext   Group root path for checkout of product. "msgmerge" will post
                process on the export result based on the current definitionFile
                in that location

So this change shouldn't result in a fixme, as it is according to the current specification.

I'll make a follow-up commit adding a todo.

#Comment by Nikerabbit (talk | contribs)   20:08, 13 March 2012

Configuration documentation states:

definitionFile
Use this to define the location of the definition file (with the English source messages) if it does not adhere to the sourcePattern. Path variables are supported.

https://www.mediawiki.org/wiki/Help:Extension:Translate/Group_configuration#FILES

FileBasedMessageGroups have method called getSourceFilePath() that could perhaps be suitable.

Status & tagging log