r113545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113544‎ | r113545 | r113546 >
Date:23:27, 9 March 2012
Author:catrope
Status:resolved (Comments)
Tags:
Comment:
(bug 34521) Returning to the previous page after logging in loses any array-valued parameters in the query string. This happens because WebRequest::getValues() calls getVal() which strips arrays, even though the doc comment says that no transformation is applied. Changed getValues() to call getGPCVal() instead. The only difference is that arrays are no longer stripped, so the doc comment is no longer a lie
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.20 (modified) (history)
  • /trunk/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebRequest.php
@@ -535,7 +535,7 @@
536536
537537 $retVal = array();
538538 foreach ( $names as $name ) {
539 - $value = $this->getVal( $name );
 539+ $value = $this->getGPCVal( $this->data, $name );
540540 if ( !is_null( $value ) ) {
541541 $retVal[$name] = $value;
542542 }
Index: trunk/phase3/RELEASE-NOTES-1.20
@@ -45,6 +45,8 @@
4646 * (bug 34929) Show the correct diff when a section edit is rejected by the spam
4747 filter
4848 * (bug 15816) Add a switch for SETting the search_path (Postgres)
 49+* (bug 34521) Returning to the previous page after logging in loses any array-
 50+ valued parameters in the query string
4951
5052 === API changes in 1.20 ===
5153 * (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.

Follow-up revisions

RevisionCommit summaryAuthorDate
r113551followup to -r113545 - add null for missing $default parambsitu00:31, 10 March 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   23:45, 9 March 2012

Missing the $default param.

Status & tagging log