r113528 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113527‎ | r113528 | r113529 >
Date:21:33, 9 March 2012
Author:foxtrott
Status:ok (Comments)
Tags:
Comment:
fix bug 33594 (timeline parameter timelineposition=today doesn't work)
Modified paths:
  • /trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/Timeline/SRF_Timeline.php
——@@ -365,7 +365,7 @@
366366 $params['timelineposition'] = new Parameter( 'timelineposition' );
367367 $params['timelineposition']->setDefault( 'middle' );
368368 $params['timelineposition']->setMessage( 'srf_paramdesc_timelineposition' );
369 - $params['timelineposition']->addCriteria( new CriterionInArray( 'start', 'middle', 'end' ) );
 369+ $params['timelineposition']->addCriteria( new CriterionInArray( 'start', 'middle', 'end', 'today' ) );
370370
371371 $params['timelinestart'] = new Parameter( 'timelinestart' );
372372 $params['timelinestart']->setDefault( '' );

Comments

#Comment by Jeroen De Dauw (talk | contribs)   21:43, 9 March 2012

>_> ok, I failed...

Status & tagging log