r113488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113487‎ | r113488 | r113489 >
Date:17:30, 9 March 2012
Author:maxsem
Status:ok
Tags:
Comment:
Bug 35086 - Expand brokens show bad labels on non-western alphabets
Modified paths:
  • /trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/templates/ApplicationTemplate.php
@@ -40,8 +40,8 @@
4141 $startLinkTag = "<link href='{$this->data['wgExtensionAssetsPath']}/MobileFrontend/stylesheets/";
4242 $endLinkTag = "' media='all' rel='Stylesheet' type='text/css' />";
4343 $filePageStyle = ( $this->data['isFilePage'] ) ? $startLinkTag . 'filepage.css' . $endLinkTag : '';
44 - $buttonHideText = htmlentities( $this->data['hideText'], ENT_QUOTES );
45 - $buttonShowText = htmlentities( $this->data['showText'], ENT_QUOTES );
 44+ $buttonHideText = Xml::escapeJsString( $this->data['hideText'] );
 45+ $buttonShowText = Xml::escapeJsString( $this->data['showText'] );
4646
4747
4848 $applicationHtml = <<<HTML

Follow-up revisions

RevisionCommit summaryAuthorDate
r113489MFT r113488awjrichards17:39, 9 March 2012
r114201MFT r113486, r113488, r113512, r113553, r113640, r113642, r113644, r113645, r...awjrichards22:18, 19 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r113442Making show/hide buttons translatableawjrichards01:21, 9 March 2012
r113444Followup r113442, using internal message array and escaping button messagesawjrichards01:32, 9 March 2012

Status & tagging log