r113458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113457‎ | r113458 | r113459 >
Date:07:22, 9 March 2012
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
partial work-around for jQuery/jQuery.elastic bug, see bug 35057
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css
——@@ -226,7 +226,7 @@
227227 }
228228
229229 /*#mw-wikilove-dialog*/ #mw-wikilove-add-details #mw-wikilove-message {
230 - width: 100%; /* some old skins don't include this by default */
 230+ width: 460px; /* don't use 100%, see bug 35057 */
231231 }
232232
233233 /*#mw-wikilove-dialog #mw-wikilove-add-details*/ #mw-wikilove-subtype-description {

Sign-offs

UserFlagDate
Krinkleinspected08:06, 9 March 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r113497MFT r113458reedy18:45, 9 March 2012
r114013partial fix for bug 35057 - backporting a patch from jQuery 1.7.2prekaldari14:44, 16 March 2012
r114016fix for bug 35057 - also suggested as an upstream change for jquery.elastickaldari15:19, 16 March 2012

Comments

#Comment by Kaldari (talk | contribs)   07:33, 9 March 2012

This works-around a 1.19 regression (although there is still an underlying bug that needs to be fixed separately).

Status & tagging log