r113203 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r113202‎ | r113203 | r113204 >
Date:00:06, 7 March 2012
Author:brion
Status:ok (Comments)
Tags:1.19, mathjax 
Comment:
fix for MathJax zoom setting: should be 'Click' not 'click'

[per feedback on mathjax-users list]
Modified paths:
  • /trunk/extensions/Math/modules/ext.math.mathjax.enabler.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Math/modules/ext.math.mathjax.enabler.js
——@@ -15,7 +15,7 @@
1616 "v1.0-compatible": false,
1717 styles: { ".mtext": { "font-family": "sans-serif ! important", "font-size": "80%" } },
1818 displayAlign: "left",
19 - menuSettings: { zoom: "click" },
 19+ menuSettings: { zoom: "Click" },
2020 "HTML-CSS": { imageFont: null, availableFonts: ["TeX"] }
2121 });
2222 MathJax.OutputJax.fontDir = mathJax.fontDir = mediaWiki.config.get('wgExtensionAssetsPath') + '/Math/modules/MathJax/fonts';

Sign-offs

UserFlagDate
He7d3rinspected21:18, 7 March 2012

Comments

#Comment by He7d3r (talk | contribs)   21:17, 7 March 2012

Er.. This remembers me that if a user is not using "English", this text (and those from the other menus) should be translated. See e.g.: http://leuksman.com/mw/index.php/Alpha_compositing?uselang=ja

#Comment by He7d3r (talk | contribs)   21:22, 7 March 2012

Bug 35038.

#Comment by Brion VIBBER (talk | contribs)   21:26, 7 March 2012

Yeah, at some point we'll want to see how we can add that in and see if they'll take the changes upstream.

Status & tagging log