r113110 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113109‎ | r113110 | r113111 >
Date:00:09, 6 March 2012
Author:reedy
Status:ok
Tags:
Comment:
Followup r113109, forward port the rest of r25267 for Bug 10788 - Filter page histories by user, or contributions by title
Modified paths:
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/sqlite/archives/patch-revision-user-page-index.sql (added) (history)
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/sqlite/archives/patch-revision-user-page-index.sql
@@ -0,0 +1,5 @@
 2+-- New index on revision table to allow searches for all edits by a given user
 3+-- to a given page. Added 2007-08-28
 4+
 5+ALTER TABLE /*$wgDBprefix*/revision
 6+ ADD INDEX page_user_timestamp (rev_page,rev_user,rev_timestamp);
Property changes on: trunk/phase3/maintenance/sqlite/archives/patch-revision-user-page-index.sql
___________________________________________________________________
Added: svn:eol-style
17 + native
Index: trunk/phase3/maintenance/tables.sql
@@ -326,6 +326,7 @@
327327 CREATE INDEX /*i*/page_timestamp ON /*_*/revision (rev_page,rev_timestamp);
328328 CREATE INDEX /*i*/user_timestamp ON /*_*/revision (rev_user,rev_timestamp);
329329 CREATE INDEX /*i*/usertext_timestamp ON /*_*/revision (rev_user_text,rev_timestamp);
 330+CREATE INDEX /*i*/page_user_timestamp ON /*_*/revision (rev_page,rev_user,rev_timestamp);
330331
331332 --
332333 -- Holds text of individual page revisions.
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -195,6 +195,7 @@
196196
197197 // 1.20
198198 array( 'addTable', 'config', 'patch-config.sql' ),
 199+ array( 'addIndex', 'revision'. 'page_user_timestamp', 'patch-revision-user-page-index.sql' ),
199200 );
200201 }
201202
Index: trunk/phase3/includes/installer/SqliteUpdater.php
@@ -74,6 +74,7 @@
7575
7676 // 1.20
7777 array( 'addTable', 'config', 'patch-config.sql' ),
 78+ array( 'addIndex', 'revision'. 'page_user_timestamp', 'patch-revision-user-page-index.sql' ),
7879 );
7980 }
8081

Follow-up revisions

RevisionCommit summaryAuthorDate
r113111And fix the . from r113110reedy00:10, 6 March 2012
r113112Can someone standardi[sz]e SQL already!?...reedy00:26, 6 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r25267* Add an index to (rev_page,rev_user,rev_timestamp) for use in "All edits by ...simetrical02:33, 29 August 2007
r25303Merged revisions 25215-25302 via svnmerge from...david07:10, 30 August 2007
r113109Pull patch-revision-user-page-index.sql from r25267reedy00:05, 6 March 2012

Status & tagging log