r113054 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r113053‎ | r113054 | r113055 >
Date:18:09, 5 March 2012
Author:catrope
Status:ok
Tags:
Comment:
Followup r112267: make $wgCustomUserSignupTrackAccountCreations enable/disable all clicktracking events
Modified paths:
  • /trunk/extensions/CustomUserSignup/CustomUserSignup.hooks.php (modified) (history)
  • /trunk/extensions/CustomUserSignup/modules/AccountCreationUserBucket.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CustomUserSignup/CustomUserSignup.hooks.php
@@ -114,6 +114,12 @@
115115 $out->addModules( 'ext.UserBuckets' );
116116 return true;
117117 }
 118+
 119+ public static function makeGlobalVariablesScript( &$vars ) {
 120+ global $wgCustomUserSignupTrackAccountCreations;
 121+ $vars['wgCustomUserSignupTrackAccountCreations'] = $wgCustomUserSignupTrackAccountCreations;
 122+ return true;
 123+ }
118124
119125 public static function addNewAccount( $user, $byEmail ){
120126 global $wgRequest, $wgTitle, $wgCustomUserSignupTrackAccountCreations;
Index: trunk/extensions/CustomUserSignup/modules/AccountCreationUserBucket.js
@@ -60,6 +60,7 @@
6161 // "allActive" is reserved.
6262 // If this function exists, it will be apply to every user not in the "none" bucket
6363 "allActive": function(){
 64+ if ( !mw.config.get( 'wgCustomUserSignupTrackAccountCreations' ) ) { return; }
6465
6566 //track account creation attempts
6667 $j("#wpCreateaccount").click(function(){ $j.trackAction('submit-signup-data'); });

Follow-up revisions

RevisionCommit summaryAuthorDate
r1130561.19wmf1: MFT r113054catrope18:13, 5 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112267Allow disabling of the ClickTracking invocation in CustomUserSignup, and disa...catrope23:19, 23 February 2012

Status & tagging log