r11305 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11304‎ | r11305 | r11306 >
Date:00:39, 12 October 2005
Author:tomgilder
Status:old
Tags:
Comment:
navbar v3 - bold links!
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE60Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/IE60Fixes.css
@@ -49,6 +49,10 @@
5050 #p-cactions li a:hover {
5151 padding-bottom: 0.17em;
5252 }
 53+#p-navigation a {
 54+ display: inline-block;
 55+ width: 100%;
 56+}
5357 #portal-personaltools {
5458 padding-bottom: 0.1em;
5559 }
@@ -77,3 +81,4 @@
7882 position: relative;
7983 }
8084 /*{ border:1px solid Red !important;}*/
 85+
Index: trunk/phase3/skins/monobook/IE55Fixes.css
@@ -57,6 +57,10 @@
5858 #p-cactions li a:hover {
5959 padding-bottom: 0.17em;
6060 }
 61+#p-navigation a {
 62+ display: inline-block;
 63+ width: 100%;
 64+}
6165 .portlet {
6266 overflow:hidden;
6367 }
Index: trunk/phase3/skins/monobook/main.css
@@ -682,10 +682,21 @@
683683 z-index: 3;
684684 }
685685
686 -#p-navigation strong {
687 - font-weight: normal;
 686+#p-navigation .pBody {
 687+ padding-right: 0;
688688 }
689689
 690+#p-navigation a {
 691+ display: block;
 692+}
 693+
 694+#p-navigation li.active a, #p-navigation li.active a:hover {
 695+ color: #000;
 696+ text-decoration: none;
 697+ display: inline;
 698+}
 699+
 700+
690701 /*
691702 ** Search portlet
692703 */
Index: trunk/phase3/skins/MonoBook.php
@@ -135,10 +135,8 @@
136136 if ( $val['active'] ) echo ' class="active"';
137137 echo '>';
138138 if ( $val['active'] ) echo '<strong>';
139 - if ( $val['dolink'] ) echo '<a href="' . htmlspecialchars($val['href']) . '">';
140 - echo htmlspecialchars($val['text']);
 139+ echo '<a href="' . htmlspecialchars($val['href']) . '">' . htmlspecialchars($val['text']) . '</a>';
141140 if ( $val['active'] ) echo '</strong>';
142 - if ( $val['dolink'] ) echo '</a>';
143141 echo '</li>';
144142 } ?>
145143 </ul>
Index: trunk/phase3/includes/Skin.php
@@ -1337,13 +1337,11 @@
13381338 if (wfEmptyMsg($line[0], $link))
13391339 $link = $line[0];
13401340 $href = $this->makeInternalOrExternalUrl( $link );
1341 - $active = ( $pageurl == $href );
13421341 $bar[$heading][] = array(
13431342 'text' => $text,
13441343 'href' => $href,
13451344 'id' => 'n-' . strtr($line[1], ' ', '-'),
1346 - 'active' => $active,
1347 - 'dolink' => ( !$active || ($action != 'view' && $action != 'purge' ) )
 1345+ 'active' => ( $pageurl == $href )
13481346 );
13491347 } else { continue; }
13501348 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r26419(bug 9718) Remove browser-dependent and redundant css introduced by r11305.amidaniel21:42, 4 October 2007
r26431Merged revisions 26331-26430 via svnmerge from...david06:44, 5 October 2007

Status & tagging log