r112931 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112930‎ | r112931 | r112932 >
Date:08:51, 3 March 2012
Author:van-de-bugger
Status:deferred (Comments)
Tags:
Comment:
Fixed link to extension page; README fixed.
Modified paths:
  • /trunk/extensions/Genderize/Genderize.php (modified) (history)
  • /trunk/extensions/Genderize/README (modified) (history)

Diff [purge]

Index: trunk/extensions/Genderize/Genderize.php
@@ -49,7 +49,7 @@
5050 'license' => 'AGPL-3.0+',
5151 'version' => '0.0.1',
5252 'author' => array( '[http://www.mediawiki.org/wiki/User:Van_de_Bugger Van de Bugger]' ),
53 - //~ 'url' => 'http://example.org/',
 53+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Genderize',
5454 'descriptionmsg' => 'genderize-description',
5555 );
5656
Index: trunk/extensions/Genderize/README
@@ -6,18 +6,29 @@
77
88 == Why? ==
99
10 -MediaWiki 1.18.0 introduced $wgExtraGenderNamespaces for it. Yes, but it does only 1/4 of the job.
11 -If you set up $wgExtraGenderNamespaces properly, tooltips of links to user pages are genderized.
12 -But link text, user page title and namespace tab are not. This extension let
13 -$wgExtraGenderNamespaces do its part of the job and does the rest.
 10+MediaWiki 1.18.0 introduced $wgExtraGenderNamespaces, but it does only part of the job. If you set
 11+up $wgExtraGenderNamespaces properly, tooltips of links to user pages and user page titles are
 12+genderized, but link text and namespace tab are not. This extension let $wgExtraGenderNamespaces do
 13+its part of the job and does the rest.
1414
 15+I believe some day all the functionality will be implemented in MediaWiki core and the Genderize
 16+extension will be obsolete. But for MediaWiki 1.18.x the Genderize fills the gap.
 17+
 18+== Download ==
 19+
 20+ svn checkout http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/Genderize
 21+
1522 == Usage ==
1623
 24+Add to your LocalSettings.php:
 25+
1726 // $egGenderize should be set *before* including `Genderize.php'.
18 - $egGenderize[ 'male' ] = 'Male';
19 - $egGenderize[ 'female' ] = 'Female';
20 - $egGenderize[ 'unknown' ] = 'Unknown';
21 - require_once( '.../Genderize.php' );
 27+ $egGenderize[ 'male' ] = 'Male'; // Replace Male, Female,
 28+ $egGenderize[ 'female' ] = 'Female'; // and Unknown with proper words
 29+ $egGenderize[ 'unknown' ] = 'Unknown'; // in wiki content language.
 30+ // Do *not* change $wgExtraGenderNamespaces[ NS_USER ].
 31+ // Include extension file:
 32+ require_once( 'path-to-extension/Genderize.php' );
2233
2334 If $egGender is not set, English `User' is used instead.
2435
@@ -25,12 +36,12 @@
2637
2738 (Let us assume $egGenderize is set as in the example above.)
2839
29 -Liтks to a user page can be specified as [[Male:Name]], [[Female:Name]], or [[Unknown:Name]], or as
 40+Links to a user page can be specified as [[Male:Name]], [[Female:Name]], or [[Unknown:Name]], or as
3041 canonical [[User:Name]]. Regardless of the used prefix, link will be rendered with proper prefix.
3142
32 -User page title will be genderized, e. g. `Female:Name'. Namespace tab (in case of Vector skin it
33 -is above the left-upper corner of the page) will be `Female', not `User'.
34 -
 43+User page title will be genderized, e. g. `Female:Name'. Namespace tab (in case of Vector skin it is
 44+above the left-upper corner of the page) will be `Female', not `User'.
 45+
3546 == Known issues ==
3647
3748 Some messages are not translated yet. For example, namespace's tab tooltip.
@@ -40,4 +51,10 @@
4152 GNU Affero General Public License, version 3 or any later version. See `AGPL-3.0.txt' file for the
4253 full license text.
4354
 55+== Links ==
 56+
 57+* Extension page: http://www.mediawiki.org/wiki/Extension:Genderize
 58+* Author page: http://www.mediawiki.org/wiki/User:Van_de_Bugger
 59+* License page: http://www.gnu.org/licenses/agpl.html
 60+
4461 <!-- end of file -->

Follow-up revisions

RevisionCommit summaryAuthorDate
r112937Feedback from Peachey88 implemented: http: protocol in links replaced with ht...van-de-bugger11:19, 3 March 2012

Comments

#Comment by P858snake (talk | contribs)   09:13, 3 March 2012
  • trunk/extensions/Genderize/Genderize.php
+	'url'     => '[http://www.mediawiki.org/wiki/Extension:Genderize', http://www.mediawiki.org/wiki/Extension:Genderize',]

Should be HTTPS

  • trunk/extensions/Genderize/README
+== Links ==
 	56	+
 	57	+* Extension page: [http://www.mediawiki.org/wiki/Extension:Genderize http://www.mediawiki.org/wiki/Extension:Genderize]
 	58	+* Author page:    [http://www.mediawiki.org/wiki/User:Van_de_Bugger http://www.mediawiki.org/wiki/User:Van_de_Bugger]
 	59	+* License page:   [http://www.gnu.org/licenses/agpl.html http://www.gnu.org/licenses/agpl.html]

MW links should be HTTPS, as well as GNU (if they support it).

#Comment by Van de Bugger (talk | contribs)   11:22, 3 March 2012

All the links changed to use https protocol (GNU site supports it). Thanks.

#Comment by P858snake (talk | contribs)   05:27, 4 March 2012

r112937 is the followup to this revision.

In future when do a revision to follow up based on another one (Eg: due to comments), please inculde the revision you are following on from in the commit summary, in the style of "rXXXXXX" somewhere in the message so they automatically link in CR.

#Comment by Van de Bugger (talk | contribs)   17:26, 5 March 2012

So, using rXXXXXX anywhere in the commit message will be automatically recognized as the revision this one follows up? Ok, I will.

Status & tagging log