r112917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112916‎ | r112917 | r112918 >
Date:20:48, 2 March 2012
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
I break it I fix it
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialTranslate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/specials/SpecialTranslate.php
@@ -142,7 +142,7 @@
143143 }
144144 $priorityLangs = array_flip( explode( ',', TranslateMetadata::get( $this->group->getId(), 'prioritylangs' ) ) );
145145 $priorityForce = TranslateMetadata::get( $this->group->getId(), 'priorityforce' );
146 - if ( !isset( $priorityLangs[$this->options['language']] ) ) {
 146+ if ( count( $priorityLangs ) && !isset( $priorityLangs[$this->options['language']] ) ) {
147147 $priorityReason = TranslateMetadata::get( $this->group->getId(), 'priorityreason' );
148148 if ( $priorityForce === 'on' ) {
149149 // Hide table

Follow-up revisions

RevisionCommit summaryAuthorDate
r112919Apparently someone thinks that explode( ',', '' ) returning array( 0 => '' ) ...nikerabbit21:02, 2 March 2012
r112920Third time the bunny jumps, ping r112917, r112919nikerabbit21:12, 2 March 2012

Comments

#Comment by Siebrand (talk | contribs)   21:02, 2 March 2012

Doesn't have the intended effect.

Status & tagging log