r112892 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112891‎ | r112892 | r112893 >
Date:13:47, 2 March 2012
Author:jdlrobson
Status:ok (Comments)
Tags:
Comment:
empty palm_pre stylesheet

definitions are now redundant with recent
styling changes
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -1,28 +1 @@
2 -#searchbox {
3 - height: 25px;
4 -}
5 -
6 -#searchbox #logo {
7 - display: block;
8 - float: left;
9 - margin-right: 4px;
10 -}
11 -
12 -#searchbox #searchField {
13 - border: 1px solid grey;
14 - height: 20px;
15 -}
16 -
17 -#searchbox #clearButton {
18 - display: block;
19 -}
20 -
21 -#nav {
22 - height: 23px;
23 -}
24 -
25 -body {
26 - font-size: 14px;
27 -}
28 -
29 -
 2+/* empty */

Comments

#Comment by Reedy (talk | contribs)   16:15, 2 March 2012

Is there a reason not to svn delete it?

Or are you keeping it incase we have to put palm pre specifics in at a later date?

#Comment by Jdlrobson (talk | contribs)   16:22, 2 March 2012

Exactly. DeviceDetection.php will attach a palm_pre.css stylesheet to pages in a palm pre web browser. We could of course remove that too to prevent 404s but I suspect that we will need this in future and it's probably not worth the hassle right now..

#Comment by Preilly (talk | contribs)   19:07, 6 March 2012

Agreed.

Status & tagging log