r112819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112818‎ | r112819 | r112820 >
Date:17:29, 1 March 2012
Author:ialex
Status:ok
Tags:
Comment:
* (bug 34849) Diff when editing an old version show the comparison with the current text again
Modified paths:
  • /branches/REL1_19/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2311,7 +2311,7 @@
23122312 function showDiff() {
23132313 global $wgUser, $wgContLang, $wgParser, $wgOut;
23142314
2315 - $oldtext = $this->getOriginalContent();
 2315+ $oldtext = $this->mArticle->getRawText();
23162316 $newtext = $this->mArticle->replaceSection(
23172317 $this->section, $this->textbox1, $this->summary, $this->edittime );
23182318
Index: branches/REL1_19/phase3/includes/EditPage.php
@@ -2306,7 +2306,7 @@
23072307 function showDiff() {
23082308 global $wgUser, $wgContLang, $wgParser, $wgOut;
23092309
2310 - $oldtext = $this->getOriginalContent();
 2310+ $oldtext = $this->mArticle->getRawText();
23112311 $newtext = $this->mArticle->replaceSection(
23122312 $this->section, $this->textbox1, $this->summary, $this->edittime );
23132313

Follow-up revisions

RevisionCommit summaryAuthorDate
r112821MFT to 1.19wmf1 r112819...hashar17:33, 1 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102997Some cleanup to Article::view() and related:...ialex18:05, 14 November 2011

Status & tagging log