r112757 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112756‎ | r112757 | r112758 >
Date:01:41, 1 March 2012
Author:raindrift
Status:deferred
Tags:
Comment:
text and css changes, per Brandon
Modified paths:
  • /trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.i18n.php (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.php (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/includes/ArticleCreationTemplates.php (modified) (history)
  • /trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/ext.articleCreation.core.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleCreationWorkflow/includes/ArticleCreationTemplates.php
@@ -11,11 +11,12 @@
1212 * @return String HTML
1313 */
1414 public static function getLandingPage( $page ) {
15 - $action = wfMessage( 'ac-action-indicator' )->escaped();
1615 global $wgUser, $wgArticleCreationButtons;
1716
1817 $title = Title::newFromText( $page );
1918
 19+ $action = wfMessage( 'ac-action-indicator', $title )->parse();
 20+
2021 $html = '';
2122 $buttons = array();
2223 $variant = self::getLandingVariant( $title );
Index: trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.i18n.php
@@ -17,7 +17,7 @@
1818 'ac-landing-page-title' => 'Create an article about "$1" on {{SITENAME}}',
1919
2020 //buttons
21 - 'ac-action-indicator' => 'I want to create an article on {{SITENAME}}...',
 21+ 'ac-action-indicator' => '{{SITENAME}} doesn\'t have an article called <b>"$1"</b>. To create it, I want to...',
2222
2323 'ac-action-login' => 'Log in to {{SITENAME}}',
2424 'ac-action-login-subtitle' => 'I have a {{SITENAME}} account.',
@@ -45,11 +45,9 @@
4646
4747 'ac-action-create' => 'Create this article myself',
4848 'ac-action-create-subtitle' => 'I\'ve done this before.',
49 - 'ac-create-warning-create' => "We value your time and want to make sure your contributions are the kind that will improve Wikipedia.
50 - Articles on Wikipedia should be about notable topics and be written in an unbiased manner.<br/><br/>
51 - Articles may be deleted if:
52 - <ul><li>they copy material from other sources, or</li>
53 - <li>are overly promotional, or</li>
 49+ 'ac-create-warning-create' => "Articles may be deleted <i><b>immediately</b></i> if:
 50+ <ul><li>they copy material from other sources</li>
 51+ <li>are overly promotional</li>
5452 <li>do not clearly state why the subject is important.</li></ul>
5553 ",
5654 'ac-create-button' => "Let's Go",
Index: trunk/extensions/ArticleCreationWorkflow/modules/ext.articleCreation.core/ext.articleCreation.core.css
@@ -1,9 +1,10 @@
22 /* Article Creation Text */
33 .article-creation-heading {
4 - font-size: 2.5em;
5 - font-weight: 590;
64 display: block;
7 - margin: 20px 0;
 5+ font-size: 1.1em;
 6+ margin-left: 80px;
 7+ margin-top: 10px;
 8+ margin-bottom: 10px;
89 }
910
1011 /* Article Creation Panel */
@@ -110,3 +111,9 @@
111112 float: right;
112113 font-size: 90%;
113114 }
 115+
 116+.mw-ac-create-dismiss-skip-control {
 117+ font-size: .5em;
 118+ float: left;
 119+ padding-top: 1em;
 120+}
Index: trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.php
@@ -157,14 +157,16 @@
158158 <div class="mw-ac-tooltip-title"><html:msg key="ac-click-tip-title-create" /></div>
159159 <div class="mw-ac-tooltip-body">
160160 <div class="mw-ac-create-verbiage"><html:msg raw="1" key="ac-create-warning-create" /></div>
161 - <input
162 - type="checkbox"
163 - id="mw-ac-dismiss-create"
164 - class="ac-dismiss-interstitial" />
165 - <label for="mw-ac-dismiss-create">
166 - <html:msg key="ac-create-dismiss" />
167 - </label>
168161 <div class="ac-button-wrap">
 162+ <div class="mw-ac-create-dismiss-skip-control">
 163+ <input
 164+ type="checkbox"
 165+ id="mw-ac-dismiss-create"
 166+ class="ac-dismiss-interstitial" />
 167+ <label for="mw-ac-dismiss-create">
 168+ <html:msg key="ac-create-dismiss" />
 169+ </label>
 170+ </div>
169171 <a class="ac-button ac-action-button" data-ac-action="create"><html:msg key="ac-create-button" /></a>
170172 </div>
171173 <div style="clear: both"></div>

Follow-up revisions

RevisionCommit summaryAuthorDate
r112760small text tweaks per Brandon, followup to r112757raindrift01:56, 1 March 2012

Status & tagging log