r112522 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112521‎ | r112522 | r112523 >
Date:21:48, 27 February 2012
Author:catrope
Status:ok
Tags:
Comment:
1.19wmf1: r112520
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/ProofreadPage (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/ProofreadPage/proofread.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/ProofreadPage/proofread.js
@@ -749,18 +749,18 @@
750750 return;
751751 }
752752 var f = text.parentNode;
753 - var new_text = f.removeChild( text );
754753
755754 if( proofreadPageIsEdit ) {
756755 pr_make_edit_area( self.text_container, new_text.value );
757 - var copywarn = document.getElementById( 'editpage-copywarn' );
758 - f.insertBefore( table, copywarn );
 756+ f.insertBefore( table, text.nextSibling ); // Inserts table after text
 757+ f.removeChild( text );
759758 if ( !self.proofreadpage_show_headers ) {
760759 hookEvent( 'load', pr_toggle_visibility );
761760 } else {
762761 hookEvent( 'load', pr_reset_size );
763762 }
764763 } else {
 764+ var new_text = f.removeChild( text );
765765 self.text_container.appendChild( new_text );
766766 f.appendChild( self.table );
767767 }
Property changes on: branches/wmf/1.19wmf1/extensions/ProofreadPage
___________________________________________________________________
Added: svn:mergeinfo
768768 Merged /trunk/extensions/ProofreadPage:r111043,111199,111218,111484,111575,111604,111659-111661,111668,111670,111688,111690,111698,111713,111715,111780,111796,111814,111947,112074,112153,112160,112166,112520
769769 Merged /branches/sqlite/extensions/ProofreadPage:r58211-58321
770770 Merged /trunk/phase3/extensions/ProofreadPage:r111002,111029,111034,111062,111067,111076,111085,111128,111144,111251
771771 Merged /branches/new-installer/phase3/extensions/ProofreadPage:r43664-66004
772772 Merged /branches/JSTesting/extensions/ProofreadPage:r100352-107913
773773 Merged /branches/REL1_15/phase3/extensions/ProofreadPage:r51646
774774 Merged /branches/wmf/1.18wmf1/extensions/ProofreadPage:r97508
775775 Merged /branches/REL1_17/phase3/extensions/ProofreadPage:r81445,81448

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112520Fix bug in proofread.js that was causing a JS error if textarea#wpTextbox1 an...catrope21:33, 27 February 2012

Status & tagging log