r112511 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112510‎ | r112511 | r112512 >
Date:20:30, 27 February 2012
Author:krinkle
Status:ok
Tags:
Comment:
[ext.codereview.styles] Make whitespace changes identifiable in CR diffs
* (bug 27375) Whitespace changes should be identifiable in CR diffs
* Also removing useless text-decoration resets on "td.ins". Probably left-over from when the selector/html was "<ins>"
Modified paths:
  • /trunk/extensions/CodeReview/modules/ext.codereview.styles.css (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.styles.css
——@@ -183,15 +183,23 @@
184184 }
185185
186186 .mw-codereview-diff td.ins {
187 - text-decoration: none;
188187 color: green;
189188 }
190189
191190 .mw-codereview-diff td.del {
192 - text-decoration: none;
193191 color: red;
194192 }
195193
 194+.mw-codereview-diff td.ins ins {
 195+ background: #EDFFED;
 196+ text-decoration: none;
 197+}
 198+
 199+.mw-codereview-diff td.del del {
 200+ background: #FFEDED;
 201+ text-decoration: none;
 202+}
 203+
196204 .mw-codereview-diff td.chunkdelimiter {
197205 background-color: #EDEDFF;
198206 color: black;

Follow-up revisions

RevisionCommit summaryAuthorDate
r112512[ext.codereview.styles] follow-up r112511: spaces to tabskrinkle20:33, 27 February 2012
r112513MFT to 1.19wmf1 r112510 r112511 r112512...hashar20:39, 27 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82064* (bug 27375) Do the diff colouring in CRreedy18:28, 13 February 2011
r84818Revert r82064, fixes bug 27416, reopens bug 27375reedy19:34, 26 March 2011

Status & tagging log