r112505 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112504‎ | r112505 | r112506 >
Date:19:05, 27 February 2012
Author:freakolowsky
Status:deferred
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/phase3/includes/installer/OracleInstaller.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/installer/OracleInstaller.php
@@ -226,6 +226,8 @@
227227 // user created or already existing, switching back to a normal connection
228228 // as the new user has all needed privileges to setup the rest of the schema
229229 // i will be using that user as _InstallUser from this point on
 230+ $this->db->close();
 231+ $this->db = false;
230232 $this->parent->setVar( '_InstallUser', $this->getVar( 'wgDBuser' ) );
231233 $this->parent->setVar( '_InstallPassword', $this->getVar( 'wgDBpassword' ) );
232234 $this->parent->setVar( '_InstallDBname', $this->getVar( 'wgDBuser' ) );
@@ -240,8 +242,8 @@
241243 */
242244 public function createTables() {
243245 $this->setupSchemaVars();
244 - $this->db->selectDB( $this->getVar( 'wgDBuser' ) );
245246 $this->db->setFlag( DBO_DDLMODE );
 247+ $this->parent->setVar( 'wgDBname', $this->getVar( 'wgDBuser' ) );
246248 $status = parent::createTables();
247249 $this->db->clearFlag( DBO_DDLMODE );
248250

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112502* partly fixes two issues exposed by bug 34280...freakolowsky19:01, 27 February 2012

Status & tagging log