r112504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112503‎ | r112504 | r112505 >
Date:19:03, 27 February 2012
Author:freakolowsky
Status:deferred
Tags:
Comment:
Modified paths:
  • /branches/REL1_19/phase3/includes/installer/OracleInstaller.php (modified) (history)

Diff [purge]

Index: branches/REL1_19/phase3/includes/installer/OracleInstaller.php
@@ -230,6 +230,8 @@
231231 // user created or already existing, switching back to a normal connection
232232 // as the new user has all needed privileges to setup the rest of the schema
233233 // i will be using that user as _InstallUser from this point on
 234+ $this->db->close();
 235+ $this->db = false;
234236 $this->parent->setVar( '_InstallUser', $this->getVar( 'wgDBuser' ) );
235237 $this->parent->setVar( '_InstallPassword', $this->getVar( 'wgDBpassword' ) );
236238 $this->parent->setVar( '_InstallDBname', $this->getVar( 'wgDBuser' ) );
@@ -244,8 +246,8 @@
245247 */
246248 public function createTables() {
247249 $this->setupSchemaVars();
248 - $this->db->selectDB( $this->getVar( 'wgDBuser' ) );
249250 $this->db->setFlag( DBO_DDLMODE );
 251+ $this->parent->setVar( 'wgDBname', $this->getVar( 'wgDBuser' ) );
250252 $status = parent::createTables();
251253 $this->db->clearFlag( DBO_DDLMODE );
252254

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112502* partly fixes two issues exposed by bug 34280...freakolowsky19:01, 27 February 2012

Status & tagging log