r112423 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112422‎ | r112423 | r112424 >
Date:11:39, 26 February 2012
Author:amire80
Status:ok (Comments)
Tags:
Comment:
Fixes bug 34723: applies the English language to CSS/JS both as a user subpage and a MediaWiki space page, and consequently applies LTR to JS and CSS in the textarea.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -4475,7 +4475,7 @@
44764476 if ( $this->isSpecialPage() ) {
44774477 // special pages are in the user language
44784478 return $wgLang;
4479 - } elseif ( $this->isCssOrJsPage() ) {
 4479+ } elseif ( $this->isCssOrJsPage() || $this->isCssJsSubpage() ) {
44804480 // css/js should always be LTR and is, in fact, English
44814481 return wfGetLangObj( 'en' );
44824482 } elseif ( $this->getNamespace() == NS_MEDIAWIKI ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r112428Follow up r112423, added release note.amire8012:26, 26 February 2012
r1136351.19wmf1 MFT rc112423 rc113599 ? rc113600 rc113606nikerabbit17:19, 12 March 2012

Comments

#Comment by Siebrand (talk | contribs)   12:15, 26 February 2012

Needs RELEASE-NOTES update.

#Comment by Amire80 (talk | contribs)   12:26, 26 February 2012

Addressed in r112423.

#Comment by Amire80 (talk | contribs)   10:54, 10 March 2012

Sorry, r112428.

Status & tagging log