r112395 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112394‎ | r112395 | r112396 >
Date:15:23, 25 February 2012
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 34528) Don't parse section name in edit section tooltips
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/includes/Skin.php (modified) (history)
  • /branches/REL1_19/phase3/HISTORY (modified) (history)
  • /branches/REL1_19/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/HISTORY (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/HISTORY
@@ -9,6 +9,7 @@
1010 parameter without setting the text parameter.
1111 * UserMailer could potentially throw a fatal error when a MailAddress object had
1212 an empty email address.
 13+* (bug 34528) Edit section tooltips show correction section name again
1314
1415 === MediaWiki 1.18.1 ===
1516 2012-01-11
Index: trunk/phase3/includes/Skin.php
@@ -1499,7 +1499,7 @@
15001500 if ( !is_null( $tooltip ) ) {
15011501 # Bug 25462: undo double-escaping.
15021502 $tooltip = Sanitizer::decodeCharReferences( $tooltip );
1503 - $attribs['title'] = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag' ), $tooltip );
 1503+ $attribs['title'] = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'replaceafter' ), $tooltip );
15041504 }
15051505 $link = Linker::link( $nt, wfMsgExt( 'editsection', array( 'language' => $lang ) ),
15061506 $attribs,
@@ -1511,7 +1511,7 @@
15121512 # we can rid of it someday.
15131513 $attribs = '';
15141514 if ( $tooltip ) {
1515 - $attribs = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'escape' ), $tooltip );
 1515+ $attribs = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'escape', 'replaceafter' ), $tooltip );
15161516 $attribs = " title=\"$attribs\"";
15171517 }
15181518 $result = null;
Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -17,6 +17,7 @@
1818 * UserMailer could potentially throw a fatal error when a MailAddress object had
1919 an empty email address.
2020 * (Bug 33087) Exchange server rejected mail sent by MediaWiki
 21+* (bug 34528) Edit section tooltips show correction section name again
2122
2223 == MediaWiki 1.18.1 ==
2324 2012-01-11
Index: branches/REL1_18/phase3/includes/Skin.php
@@ -1516,7 +1516,7 @@
15171517 if ( !is_null( $tooltip ) ) {
15181518 # Bug 25462: undo double-escaping.
15191519 $tooltip = Sanitizer::decodeCharReferences( $tooltip );
1520 - $attribs['title'] = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag' ), $tooltip );
 1520+ $attribs['title'] = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'replaceafter' ), $tooltip );
15211521 }
15221522 $link = Linker::link( $nt, wfMsgExt( 'editsection', array( 'language' => $lang ) ),
15231523 $attribs,
@@ -1528,7 +1528,7 @@
15291529 # we can rid of it someday.
15301530 $attribs = '';
15311531 if ( $tooltip ) {
1532 - $attribs = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'escape' ), $tooltip );
 1532+ $attribs = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'escape', 'replaceafter' ), $tooltip );
15331533 $attribs = " title=\"$attribs\"";
15341534 }
15351535 $result = null;
Index: branches/REL1_19/phase3/HISTORY
@@ -9,6 +9,7 @@
1010 parameter without setting the text parameter.
1111 * UserMailer could potentially throw a fatal error when a MailAddress object had
1212 an empty email address.
 13+* (bug 34528) Edit section tooltips show correction section name again
1314
1415 === MediaWiki 1.18.1 ===
1516 2012-01-11
Index: branches/REL1_19/phase3/includes/Skin.php
@@ -1499,7 +1499,7 @@
15001500 if ( !is_null( $tooltip ) ) {
15011501 # Bug 25462: undo double-escaping.
15021502 $tooltip = Sanitizer::decodeCharReferences( $tooltip );
1503 - $attribs['title'] = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag' ), $tooltip );
 1503+ $attribs['title'] = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'replaceafter' ), $tooltip );
15041504 }
15051505 $link = Linker::link( $nt, wfMsgExt( 'editsection', array( 'language' => $lang ) ),
15061506 $attribs,
@@ -1511,7 +1511,7 @@
15121512 # we can rid of it someday.
15131513 $attribs = '';
15141514 if ( $tooltip ) {
1515 - $attribs = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'escape' ), $tooltip );
 1515+ $attribs = wfMsgExt( 'editsectionhint', array( 'language' => $lang, 'parsemag', 'escape', 'replaceafter' ), $tooltip );
15161516 $attribs = " title=\"$attribs\"";
15171517 }
15181518 $result = null;

Follow-up revisions

RevisionCommit summaryAuthorDate
r113450MFT r112395: Don't parse section name in edit section tooltipststarling01:45, 9 March 2012

Comments

#Comment by Platonides (talk | contribs)   15:27, 25 February 2012

Apparently good, but needs parser tests.

#Comment by SPQRobin (talk | contribs)   22:26, 26 February 2012

Great that it's fixed in 1.18 & 1.19 branches too, but I suppose it can then also be fixed in 1.19wmf1?

Status & tagging log