r112366 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112365‎ | r112366 | r112367 >
Date:22:41, 24 February 2012
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
(bug 34659) Preserved Special:Contribs/newbies for now, at least in 1.19wmf deployment
Modified paths:
  • /branches/wmf/1.19wmf1/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/specials/SpecialContributions.php
@@ -44,19 +44,19 @@
4545 $this->opts = array();
4646 $request = $this->getRequest();
4747
48 - if ( $par == 'newbies' ) {
49 - $target = 'newbies';
50 - $this->opts['contribs'] = 'newbie';
51 - } elseif ( $par !== null ) {
 48+ if ( $par !== null ) {
5249 $target = $par;
5350 } else {
5451 $target = $request->getVal( 'target' );
5552 }
5653
5754 // check for radiobox
58 - if ( $request->getVal( 'contribs' ) == 'newbie' ) {
 55+ if ( $par == 'newbies' ) { // b/c
5956 $target = 'newbies';
6057 $this->opts['contribs'] = 'newbie';
 58+ } elseif ( $request->getVal( 'contribs' ) == 'newbie' ) {
 59+ $target = 'newbies';
 60+ $this->opts['contribs'] = 'newbie';
6161 } else {
6262 $this->opts['contribs'] = 'user';
6363 }

Comments

#Comment by Awjrichards (talk | contribs)   21:45, 16 March 2012

I know the issue here is addressed in the release notes (r110620), but shouldn't these changes be made in trunk as well?

#Comment by Aaron Schulz (talk | contribs)   05:57, 17 March 2012

The changes were added here just to buy some time before making the "breaking change". We shouldn't need to carry this over again to next branch.

Status & tagging log