r112358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112357‎ | r112358 | r112359 >
Date:21:29, 24 February 2012
Author:rmoen
Status:ok
Tags:
Comment:
suppressed feedback comment in log per bug 34097
Modified paths:
  • /trunk/extensions/MoodBar/ApiMoodBar.php (modified) (history)
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -159,7 +159,7 @@
160160 'moodbar-log-hide' => 'hid [[$1]]',
161161 'moodbar-log-feedback' => 'MoodBar Feedback [[$1]]',
162162 'moodbar-log-restore' => 'restored the visibility for [[$1]]',
163 - 'moodbar-log-reason' => '$1: $2',
 163+ 'moodbar-log-reason' => '$1',
164164 //Feedback Response
165165 'moodbar-response-terms' => 'By submitting, you agree to transparency under these $1.',
166166 'moodbar-response-link' => 'terms',
@@ -335,7 +335,7 @@
336336 * $1 is a link to a feedback item.',
337337 'moodbar-log-restore' => 'Log Action text for restoring feedback [[$1]] is link to feedback item',
338338 'moodbar-log-reason' => '{{optional}}
339 -Text for log reason. $1 is moodbar type, $2 is moodbar comment',
 339+Text for log reason. $1 is moodbar type',
340340 'moodbar-response-terms' => 'Text of the user license agreement. Parameters:
341341 * $1 {{msg-mw|moodbar-response-link}}',
342342 'moodbar-response-link' => 'Terms of Use Text',
Index: trunk/extensions/MoodBar/ApiMoodBar.php
@@ -36,7 +36,7 @@
3737
3838 public function logFeedback( $params, $itemId ) {
3939 $title = SpecialPage::getTitleFor( 'FeedbackDashboard', $itemId );
40 - $reason = wfMessage( 'moodbar-log-reason' )->params( $params['type'], $params['comment'] )->text();
 40+ $reason = wfMessage( 'moodbar-log-reason' )->params( $params['type'] )->text();
4141 $log = new LogPage( 'moodbar' );
4242 $log->addEntry( 'feedback', $title, $reason );
4343 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112385r112358: Message key to be ignored now for translatewiki.net because the mess...raymond09:01, 25 February 2012

Status & tagging log