r112276 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112275‎ | r112276 | r112277 >
Date:00:04, 24 February 2012
Author:rmoen
Status:deferred
Tags:
Comment:
Fixed bug when moving cursor with click. Calling showCursor after input regains focus prevents browser from freakishly scrolling
Modified paths:
  • /trunk/extensions/VisualEditor/modules/ve/es/ve.es.Surface.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/ve/es/ve.es.Surface.js
@@ -380,9 +380,6 @@
381381 );
382382 this.mouse.selectedRange = selection.clone();
383383 }
384 - //cancel ime mode by losing focus
385 - this.$input.blur();
386 - this.$input.focus();
387384 }
388385
389386 var _this = this;
@@ -407,6 +404,12 @@
408405 select();
409406 }
410407
 408+ //cancel input modes
 409+ this.resetText();
 410+ //end ime
 411+ this.$input.blur();
 412+ this.$input.focus();
 413+ this.showCursor();
411414 return false;
412415 };
413416

Follow-up revisions

RevisionCommit summaryAuthorDate
r112278follow up to r112276, fixed bug which prevented word selectionrmoen00:32, 24 February 2012

Status & tagging log