r112271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112270‎ | r112271 | r112272 >
Date:23:23, 23 February 2012
Author:catrope
Status:deferred
Tags:
Comment:
1.18wmf1: MFT r112267
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CustomUserSignup (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CustomUserSignup/CustomUserSignup.hooks.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CustomUserSignup/CustomUserSignup.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CustomUserSignup/CustomUserSignup.php
@@ -44,6 +44,8 @@
4545
4646 $wgCustomUserSignupVersion = 1;
4747 $wgCustomUserSignupSetBuckets = true;
 48+// If true, log each account creation to ClickTracking
 49+$wgCustomUserSignupTrackAccountCreations = false;
4850 // For Account Creation Project
4951 ClickTrackingHooks::addCampaign($dir. 'modules', 'CustomUserSignup/modules', 'AccountCreationUserBucket' );
5052
Index: branches/wmf/1.18wmf1/extensions/CustomUserSignup/CustomUserSignup.hooks.php
@@ -116,7 +116,7 @@
117117 }
118118
119119 public static function addNewAccount( $user, $byEmail ){
120 - global $wgRequest, $wgTitle;
 120+ global $wgRequest, $wgTitle, $wgCustomUserSignupTrackAccountCreations;
121121 $buckets = ClickTrackingHooks::unpackBucketInfo();
122122 if(isset($buckets['AccountCreation']) && $buckets['AccountCreation'][0] != "none"){
123123
@@ -126,7 +126,7 @@
127127 time() + 60 * 60 * 24 * 365 , '/' );
128128
129129 $session = $wgRequest->getCookie( 'clicktracking-session', "" );
130 - if ( $session !== null ) {
 130+ if ( $session !== null && $wgCustomUserSignupTrackAccountCreations ) {
131131 $params = new FauxRequest( array(
132132 'action' => 'clicktracking',
133133 'eventid' => 'account-created',
Property changes on: branches/wmf/1.18wmf1/extensions/CustomUserSignup
___________________________________________________________________
Added: svn:mergeinfo
134134 Merged /branches/REL1_17/phase3/extensions/CustomUserSignup:r81445,81448
135135 Merged /trunk/extensions/CustomUserSignup:r95614,99592,99653,100092,100419,100516,100686,100692,100699,103260,103315,103378,103382,103669,104337,104736,104862-104863,104865,104971,105275,105902,105908,107043,107050,107337,107783,107816,107818,108701,108789,109532,109536,109542,112267
136136 Merged /branches/sqlite/extensions/CustomUserSignup:r58211-58321
137137 Merged /trunk/phase3/extensions/CustomUserSignup:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93520,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94235,94277,94346,94372,94422,94425,94444,94448,94456,94498,94517,94601,94630,94728,94738,94825,94862,94995-94997,95023,95042,95072-95073,95155,95327,95332,95410,95422,95426,95442,95468,95601,95812,98578,98598,98656
138138 Merged /branches/new-installer/phase3/extensions/CustomUserSignup:r43664-66004
139139 Merged /branches/REL1_15/phase3/extensions/CustomUserSignup:r51646
140140 Merged /branches/REL1_18/extensions/CustomUserSignup:r101758,103190

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112267Allow disabling of the ClickTracking invocation in CustomUserSignup, and disa...catrope23:19, 23 February 2012

Status & tagging log