r112270 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112269‎ | r112270 | r112271 >
Date:23:21, 23 February 2012
Author:catrope
Status:ok
Tags:
Comment:
1.19wmf1: MFT r112267
Modified paths:
  • /branches/wmf/1.19wmf1/extensions/CustomUserSignup (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/CustomUserSignup/CustomUserSignup.hooks.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/CustomUserSignup/CustomUserSignup.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/CustomUserSignup/CustomUserSignup.php
@@ -44,6 +44,8 @@
4545
4646 $wgCustomUserSignupVersion = 1;
4747 $wgCustomUserSignupSetBuckets = true;
 48+// If true, log each account creation to ClickTracking
 49+$wgCustomUserSignupTrackAccountCreations = false;
4850 // For Account Creation Project
4951 if ( class_exists( 'ClickTrackingHooks' ) ) {
5052 ClickTrackingHooks::addCampaign($dir. 'modules', 'CustomUserSignup/modules', 'AccountCreationUserBucket' );
Index: branches/wmf/1.19wmf1/extensions/CustomUserSignup/CustomUserSignup.hooks.php
@@ -116,7 +116,7 @@
117117 }
118118
119119 public static function addNewAccount( $user, $byEmail ){
120 - global $wgRequest, $wgTitle;
 120+ global $wgRequest, $wgTitle, $wgCustomUserSignupTrackAccountCreations;
121121 $buckets = ClickTrackingHooks::unpackBucketInfo();
122122 if(isset($buckets['AccountCreation']) && $buckets['AccountCreation'][0] != "none"){
123123
@@ -126,7 +126,7 @@
127127 time() + 60 * 60 * 24 * 365 , '/' );
128128
129129 $session = $wgRequest->getCookie( 'clicktracking-session', "" );
130 - if ( $session !== null ) {
 130+ if ( $session !== null && $wgCustomUserSignupTrackAccountCreations ) {
131131 $params = new FauxRequest( array(
132132 'action' => 'clicktracking',
133133 'eventid' => 'account-created',
Property changes on: branches/wmf/1.19wmf1/extensions/CustomUserSignup
___________________________________________________________________
Added: svn:mergeinfo
134134 Merged /branches/REL1_17/phase3/extensions/CustomUserSignup:r81445,81448
135135 Merged /trunk/extensions/CustomUserSignup:r111043,111199,111218,111484,111575,111604,111659-111661,111668,111670,111688,111690,111698,111713,111715,111780,111796,111814,111947,112074,112153,112160,112166,112267
136136 Merged /branches/sqlite/extensions/CustomUserSignup:r58211-58321
137137 Merged /trunk/phase3/extensions/CustomUserSignup:r111002,111029,111034,111062,111067,111076,111085,111128,111144,111251
138138 Merged /branches/new-installer/phase3/extensions/CustomUserSignup:r43664-66004
139139 Merged /branches/JSTesting/extensions/CustomUserSignup:r100352-107913
140140 Merged /branches/REL1_15/phase3/extensions/CustomUserSignup:r51646
141141 Merged /branches/wmf/1.18wmf1/extensions/CustomUserSignup:r97508

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112267Allow disabling of the ClickTracking invocation in CustomUserSignup, and disa...catrope23:19, 23 February 2012

Status & tagging log