r112052 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112051‎ | r112052 | r112053 >
Date:22:08, 21 February 2012
Author:tparscal
Status:ok
Tags:
Comment:
Adds a supportsURLLoading method which returns false to user tokens and user options modules. This prevents them from being linked to direction which fixes an issue where in debug mode logged in users were being served anon tokens and options. This should resolve bug #34469.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php (modified) (history)
  • /trunk/phase3/includes/resourceloader/ResourceLoaderUserTokensModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php
——@@ -80,6 +80,13 @@
8181 }
8282
8383 /**
 84+ * @return bool
 85+ */
 86+ public function supportsURLLoading() {
 87+ return false;
 88+ }
 89+
 90+ /**
8491 * @return string
8592 */
8693 public function getGroup() {
Index: trunk/phase3/includes/resourceloader/ResourceLoaderUserTokensModule.php
——@@ -55,6 +55,13 @@
5656 }
5757
5858 /**
 59+ * @return bool
 60+ */
 61+ public function supportsURLLoading() {
 62+ return false;
 63+ }
 64+
 65+ /**
5966 * @return string
6067 */
6168 public function getGroup() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r1120551.19wmf1: MFT r112052catrope22:40, 21 February 2012

Status & tagging log