r112036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112035‎ | r112036 | r112037 >
Date:19:56, 21 February 2012
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
Pass __METHOD__ to DatabaseBase::begin() and DatabaseBase::commit()
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
——@@ -3476,7 +3476,7 @@
34773477 RepoGroup::singleton()->clearCache( $nt ); # clear false negative cache
34783478 }
34793479
3480 - $dbw->begin(); # If $file was a LocalFile, its transaction would have closed our own.
 3480+ $dbw->begin( __METHOD__ ); # If $file was a LocalFile, its transaction would have closed our own.
34813481 $pageid = $this->getArticleID( self::GAID_FOR_UPDATE );
34823482 $protected = $this->isProtected();
34833483
——@@ -3548,7 +3548,7 @@
35493549 WatchedItem::duplicateEntries( $this, $nt );
35503550 }
35513551
3552 - $dbw->commit();
 3552+ $dbw->commit( __METHOD__ );
35533553
35543554 wfRunHooks( 'TitleMoveComplete', array( &$this, &$nt, &$wgUser, $pageid, $redirid ) );
35553555 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r112051Per Aaron, follow-up r112036: add __METHOD__ to DatabaseBase::rollback() tooialex22:04, 21 February 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   20:28, 21 February 2012

rollback() does not have __METHOD__

#Comment by IAlex (talk | contribs)   20:38, 21 February 2012

I don't see any link between this revision and rollback().

#Comment by Aaron Schulz (talk | contribs)   21:04, 21 February 2012 
3486 	# @todo FIXME: What about the File we have already moved?
3487 	$dbw->rollback();

Does rollback not need __METHOD__? That seems wrong.

#Comment by IAlex (talk | contribs)   22:05, 21 February 2012

Corrected in r112051.

Status & tagging log