r112013 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112012‎ | r112013 | r112014 >
Date:13:30, 21 February 2012
Author:jdlrobson
Status:ok (Comments)
Tags:
Comment:
clean up css duplicate definitions

warning: again many of these rules do not appear in
wii.css and kindle.css
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/beta_common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
——@@ -89,10 +89,3 @@
9090 padding: 1em 0;
9191 font-size: 80%;
9292 }
93 -
94 -.content_block,
95 -.section_anchors,
96 -button.section_heading.hide {
97 - display: none;
98 -}
99 -
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -630,3 +630,19 @@
631631 span.citation:target, cite:target {
632632 background-color: #ddeeff;
633633 }
 634+
 635+.content_block,
 636+.section_anchors,
 637+button.section_heading.hide {
 638+ display: none;
 639+}
 640+
 641+#nav {
 642+ display: none;
 643+ width: 172px;
 644+ border: 1px solid #cccccc;
 645+ border-top: 0px;
 646+ margin: -1px 0 0 0;
 647+ background: white;
 648+ padding: 0 5px 5px 5px;
 649+}
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
——@@ -5,11 +5,6 @@
66 width: 27px;
77 }
88
9 -.content_block,
10 -.section_anchors,
11 -button.section_heading.hide {
12 - display: none;
13 -}
149
1510 #header, #footer, #content_wrapper {
1611 margin: 0 2px;
——@@ -37,6 +32,7 @@
3833 display: none;
3934 }
4035
 36+/* TODO: duplicate see psp.css */
4137 .nav {
4238 border: 0;
4339 border-bottom: 2px solid #6d84b4;
——@@ -47,10 +43,6 @@
4844 margin: 0;
4945 }
5046
51 -#nav {
52 - padding: 5px 0 5px 0;
53 -}
54 -
5547 .mwm-notice {
5648 text-align: left;
5749 }
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -5,12 +5,6 @@
66 width: 27px;
77 }
88
9 -.content_block,
10 -.section_anchors,
11 -button.section_heading.hide {
12 - display: none;
13 -}
14 -
159 #searchbox {
1610 height: 25px;
1711 }
——@@ -33,13 +27,6 @@
3428
3529 #nav {
3630 height: 23px;
37 - display: none;
38 - width: 172px;
39 - border: 1px solid #cccccc;
40 - border-top: 0px;
41 - margin: -1px 0 0 0;
42 - background: white;
43 - padding: 0 5px 5px 5px;
4431 }
4532
4633 body {
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
——@@ -5,12 +5,6 @@
66 width: 27px;
77 }
88
9 -.content_block,
10 -.section_anchors,
11 -button.section_heading.hide {
12 - display: none;
13 -}
14 -
159 body {
1610 font-size: 1.8em;
1711 }
——@@ -20,12 +14,5 @@
2115 }
2216
2317 #nav {
24 - display: none;
2518 width: 250px;
26 - border: 1px solid #cccccc;
27 - border-top: 0px;
28 - margin: -1px 0 0 0;
29 - background: white;
30 - padding: 0 5px 5px 5px;
3119 }
32 -
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
——@@ -5,27 +5,11 @@
66 width: 27px;
77 }
88
9 -.content_block,
10 -.section_anchors,
11 -button.section_heading.hide {
12 - display: none;
13 -}
14 -
159 #clearButton {
1610 display: none;
1711 }
1812
1913 #nav {
20 - display: none;
21 - width: 172px;
22 - border: 1px solid #cccccc;
23 - border-top: 0px;
24 - margin: -1px 0 0 0;
25 - background: white;
26 - padding: 0 5px 5px 5px;
27 -}
28 -
29 -#nav {
3014 margin-top: 8px;
3115 }
3216
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
——@@ -5,12 +5,6 @@
66 width: 27px;
77 }
88
9 -.content_block,
10 -.section_anchors,
11 -button.section_heading.hide {
12 - display: none;
13 -}
14 -
159 #header, #footer, #content_wrapper {
1610 margin: 0 2px;
1711 }
——@@ -37,6 +31,9 @@
3832 display: none;
3933 }
4034
 35+/* TODO: review duplicate definition in operamini, psp, simple
 36+Are they even necessary? could/should they be in common.css ?
 37+*/
4138 .nav {
4239 border: 0;
4340 border-bottom: 2px solid #6d84b4;
——@@ -47,10 +44,6 @@
4845 margin: 0;
4946 }
5047
51 -#nav {
52 - padding: 5px 0 5px 0;
53 -}
54 -
5548 .mwm-notice {
5649 text-align: left;
5750 }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
——@@ -14,26 +14,10 @@
1515 border: 1px solid grey;
1616 }
1717
18 -.content_block,
19 -.section_anchors,
20 -button.section_heading.hide {
21 - display: none;
22 -}
23 -
2418 #clearButton {
2519 display: none;
2620 }
2721
28 -#nav {
29 - display: none;
30 - width: 172px;
31 - border: 1px solid #cccccc;
32 - border-top: 0px;
33 - margin: -1px 0 0 0;
34 - background: white;
35 - padding: 0 5px 5px 5px;
36 -}
37 -
3822 #header {
3923 max-width: 290px;
4024 }
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
——@@ -16,24 +16,7 @@
1717 }
1818 }
1919
20 -.content_block,
21 -.section_anchors,
22 -button.section_heading.hide {
23 - display: none;
24 -}
25 -
2620 #clearButton {
2721 display: none;
2822 }
2923
30 -#nav {
31 - display: none;
32 - width: 172px;
33 - border: 1px solid #cccccc;
34 - border-top: 0px;
35 - margin: -1px 0 0 0;
36 - background: white;
37 - padding: 0 5px 5px 5px;
38 -}
39 -
40 -
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
——@@ -9,22 +9,6 @@
1010 width: 27px;
1111 }
1212
13 -.content_block,
14 -.section_anchors,
15 -button.section_heading.hide {
16 - display: none;
17 -}
18 -
1913 #clearButton {
2014 display: none;
2115 }
22 -
23 -#nav {
24 - display: none;
25 - width: 172px;
26 - border: 1px solid #cccccc;
27 - border-top: 0px;
28 - margin: -1px 0 0 0;
29 - background: white;
30 - padding: 0 5px 5px 5px;
31 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
——@@ -15,16 +15,6 @@
1616 display: none;
1717 }
1818
19 -#nav {
20 - display: none;
21 - width: 172px;
22 - border: 1px solid #cccccc;
23 - border-top: 0px;
24 - margin: -1px 0 0 0;
25 - background: white;
26 - padding: 0 5px 5px 5px;
27 -}
28 -
2919 #ogg_player_1 {
3020 display: none;
3121 }
Index: trunk/extensions/MobileFrontend/stylesheets/beta_common.css
——@@ -655,3 +655,19 @@
656656 span.citation:target, cite:target {
657657 background-color: #ddeeff;
658658 }
 659+
 660+.content_block,
 661+.section_anchors,
 662+button.section_heading.hide {
 663+ display: none;
 664+}
 665+
 666+#nav {
 667+ display: none;
 668+ width: 172px;
 669+ border: 1px solid #cccccc;
 670+ border-top: 0px;
 671+ margin: -1px 0 0 0;
 672+ background: white;
 673+ padding: 0 5px 5px 5px;
 674+}
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
——@@ -5,11 +5,6 @@
66 width: 27px;
77 }
88
9 -.content_block,
10 -.section_anchors,
11 -button.section_heading.hide {
12 - display: none;
13 -}
149
1510 #header, #footer, #content_wrapper {
1611 margin: 0 2px;
——@@ -37,6 +32,7 @@
3833 display: none;
3934 }
4035
 36+/* TODO: duplicate see psp.css */
4137 .nav {
4238 border: 0;
4339 border-bottom: 2px solid #6d84b4;
——@@ -47,10 +43,6 @@
4844 margin: 0;
4945 }
5046
51 -#nav {
52 - padding: 5px 0 5px 0;
53 -}
54 -
5547 .mwm-notice {
5648 text-align: left;
5749 }
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
——@@ -5,11 +5,3 @@
66 height: 25px;
77 width: 27px;
88 }
9 -
10 -.content_block,
11 -.section_anchors,
12 -button.section_heading.hide {
13 - display: none;
14 -}
15 -
16 -
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
——@@ -16,23 +16,8 @@
1717 }
1818 }
1919
20 -.content_block,
21 -.section_anchors,
22 -button.section_heading.hide {
23 - display: none;
24 -}
25 -
2620 #clearButton {
2721 display: none;
2822 }
2923
30 -#nav {
31 - display: none;
32 - width: 172px;
33 - border: 1px solid #cccccc;
34 - border-top: 0px;
35 - margin: -1px 0 0 0;
36 - background: white;
37 - padding: 0 5px 5px 5px;
38 -}
3924

Follow-up revisions

RevisionCommit summaryAuthorDate
r112121fix regression in javascript disabled view...jdlrobson17:34, 22 February 2012

Comments

#Comment by Robmoen (talk | contribs)   22:03, 21 February 2012

Not critical but is the padding change for all clients intentional?

Status & tagging log