r111991 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111990‎ | r111991 | r111992 >
Date:04:57, 21 February 2012
Author:amire80
Status:ok (Comments)
Tags:
Comment:
Displaying the language name in the current user's language. Should work with cldr installed. Ping r111614.
Modified paths:
  • /trunk/extensions/Translate/TranslateHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateHooks.php
——@@ -328,7 +328,7 @@
329329
330330 if ( $action === 'group' ) {
331331 $languageCode = $params[0];
332 - $languageNames = Language::getTranslatedLanguageNames( $languageCode );
 332+ $languageNames = Language::getTranslatedLanguageNames( $language->getCode() );
333333 $languageName = "$languageNames[$languageCode] ($languageCode)";
334334 $groupLabel = $params[1];
335335 $oldState = $params[2];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111614live hack to deal with 500s on log/RC viewsaaron02:48, 16 February 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   08:18, 22 February 2012

Needs a code comment or something.

#Comment by Nikerabbit (talk | contribs)   08:24, 22 February 2012

Why?

#Comment by Aaron Schulz (talk | contribs)   08:26, 22 February 2012

Otherwise someone might have it go back to the way it was before, thinking it's better.

#Comment by Nikerabbit (talk | contribs)   08:27, 22 February 2012

I don't think anybody would do that that way. Language::getLanguageNames is more likely and doesn't have that problem.

#Comment by Reedy (talk | contribs)   22:08, 23 February 2012

I think this needs a revision or 2 merging into 1.19wmf1 first...

#Comment by Nikerabbit (talk | contribs)   07:34, 24 February 2012

Which ones?

#Comment by Reedy (talk | contribs)   14:57, 24 February 2012

Not sure. Try and merge this into 1.19wmf1 ;)

Status & tagging log