r111969 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111968‎ | r111969 | r111970 >
Date:21:49, 20 February 2012
Author:hashar
Status:ok (Comments)
Tags:
Comment:
MFT to 1.19wmf1 r111965 r11967

bug #34495 — patrol log credit the user patrolled, not the user patrolling
Modified paths:
  • /branches/wmf/1.19wmf1/includes/logging/PatrolLog.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/logging/PatrolLog.php
@@ -27,10 +27,12 @@
2828
2929 $title = Title::makeTitleSafe( $rc->getAttribute( 'rc_namespace' ), $rc->getAttribute( 'rc_title' ) );
3030 if( $title ) {
 31+ global $wgUser;
 32+
3133 $entry = new ManualLogEntry( 'patrol', 'patrol' );
3234 $entry->setTarget( $title );
3335 $entry->setParameters( self::buildParams( $rc, $auto ) );
34 - $entry->setPerformer( User::newFromName( $rc->getAttribute( 'rc_user_text' ), false ) );
 36+ $entry->setPerformer( $wgUser );
3537 $logid = $entry->insert();
3638 if ( !$auto ) {
3739 $entry->publish( $logid, 'udp' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111965fix bug #34495 — patrol log credit the user patrolled, not the user patrollingmah21:36, 20 February 2012
r111967Fix parse error from r111965ialex21:39, 20 February 2012

Comments

#Comment by 😂 (talk | contribs)   21:55, 20 February 2012

Every time you use an emdash, it gets botched in my e-mail: ?\226?\128?\148

#Comment by Hashar (talk | contribs)   21:56, 20 February 2012

Sorry about your mail client :-( I have copy pasted that message from Hexmode commit message in r111965

Status & tagging log