r111800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111799‎ | r111800 | r111801 >
Date:22:49, 17 February 2012
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Add both size *and* size difference on history page per bug 34449
Modified paths:
  • /trunk/phase3/includes/actions/HistoryAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/HistoryAction.php
——@@ -576,7 +576,8 @@
577577 # Size is always public data
578578 $prevSize = $prevRev ? $prevRev->getSize() : 0;
579579 $sDiff = ChangesList::showCharacterDifference( $prevSize, $rev->getSize() );
580 - $s .= ' . . ' . $sDiff . ' . . ';
 580+ $fSize = Linker::formatRevisionSize($rev->getSize());
 581+ $s .= "' . . $fSize $sDiff . . ";
581582
582583 $s .= Linker::revComment( $rev, false, true );
583584

Follow-up revisions

RevisionCommit summaryAuthorDate
r111801MFT r111800werdna22:50, 17 February 2012
r111827Fix extraneous quote from r111800...reedy14:28, 18 February 2012
r111828MFT r111827 to fix r111800, r111801reedy14:31, 18 February 2012

Comments

#Comment by PleaseStand (talk | contribs)   02:17, 18 February 2012

There is a single quote that should not be there; look at any history page on any 1.19 wiki.

#Comment by Nikerabbit (talk | contribs)   09:42, 18 February 2012

The total size was already in the tooltip of the change size. I think that history page is already cluttered enough and we should try to make clearer, not more cluttered.

#Comment by Werdna (talk | contribs)   20:02, 22 February 2012

See the conversation on the bug.

Status & tagging log