r111785 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111784‎ | r111785 | r111786 >
Date:21:03, 17 February 2012
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
use generic DIRECTORY_SEPARATOR
Modified paths:
  • /trunk/extensions/HelloWorld/HelloWorld.php (modified) (history)

Diff [purge]

Index: trunk/extensions/HelloWorld/HelloWorld.php
@@ -43,7 +43,8 @@
4444 'descriptionmsg' => 'helloworld-desc',
4545 );
4646
47 -$dir = dirname( __FILE__ ) . '/';
 47+// The full directory path for this extension
 48+$dir = dirname( __FILE__ ) . DIRECTORY_SEPARATOR;
4849
4950 // Load the HelloWorld special page class
5051 $wgAutoloadClasses['SpecialHelloWorld'] = $dir . 'SpecialHelloWorld.php';

Comments

#Comment by Nikerabbit (talk | contribs)   21:21, 17 February 2012

Where doesn't simple / work?

Status & tagging log