r111745 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111744‎ | r111745 | r111746 >
Date:12:24, 17 February 2012
Author:jdlrobson
Status:ok (Comments)
Tags:
Comment:
explanatory comment

explain why the fixtures must remove
the banner that an extension might sometimes add
Modified paths:
  • /trunk/extensions/MobileFrontend/tests/js/fixtures.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/tests/js/fixtures.js
@@ -1,6 +1,8 @@
22 window.MobileFrontendTests = {
33 cleanFixtures: function() {
4 - $("#zero-rated-banner").remove(); // remove remnants from another test somewhere in test suite
 4+ // note the ZeroRatedMobileAccess extension attaches a banner to the qunit test suite
 5+ // this makes sure it is removed
 6+ $("#zero-rated-banner").remove();
57 $("#qunit-fixture-x").remove();
68 },
79 createFixtures: function() {

Comments

#Comment by Preilly (talk | contribs)   12:52, 17 February 2012

Thanks, for adding this more description comment.

Status & tagging log