r111713 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111712‎ | r111713 | r111714 >
Date:01:48, 17 February 2012
Author:siebrand
Status:ok (Comments)
Tags:i18nreview, performance 
Comment:
Split up the 4.7MB WikimediaLicenseTexts.i18n.php into two files to address Out of Memory issues that were quick fixed in r111606. Files still need to be rebuilt. Will be done in a subsequent commit.

Still not a long term solution. There probably other i18n files for extensions knocking on the OoM door:
* AbuseFilter.i18n.php (2.77MB)
* WikiEditor.i18n.php (2.02MB)
Modified paths:
  • /trunk/extensions/WikimediaMessages/WikimediaCCLicenseTexts.i18n.php (added) (history)
  • /trunk/extensions/WikimediaMessages/WikimediaLicenseTexts.i18n.php (modified) (history)
  • /trunk/extensions/WikimediaMessages/WikimediaLicenseTexts.php (modified) (history)
  • /trunk/translatewiki/MediaWiki/WikimediaMainAgg.yaml (modified) (history)
  • /trunk/translatewiki/MediaWiki/mediawiki-defines.txt (modified) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

RevisionCommit summaryAuthorDate
r111715Follow-up r111713: Rebuild WikimediaCCLicenseTexts.i18n.php and WikimediaLice...siebrand01:57, 17 February 2012
r111772MFT r111713, r111715reedy18:29, 17 February 2012
r111773MFT r111713, r111715reedy18:37, 17 February 2012
r111774MFT r111713, r111715reedy18:41, 17 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111606Remove everything except english from WikimediaLicenseTexts.i18n.php, to avoi...tstarling01:26, 16 February 2012

Comments

#Comment by Reedy (talk | contribs)   18:07, 17 February 2012 
// Load our site-specific l10n extensions
include "$IP/extensions/WikimediaMessages/WikimediaMessages.php";
if ( $wmgUseWikimediaLicenseTexts ) {
    include "$IP/extensions/WikimediaMessages/WikimediaLicenseTexts.php";
}

I'm wondering if we should do this to both 1.18wmf1 and 1.19wmf1, purely so we don't have to do a per version hack in CommonSettings.php per the above

#Comment by Reedy (talk | contribs)   18:46, 17 February 2012

Ignore that.

Done it to both anyway

#Comment by Reedy (talk | contribs)   21:57, 17 February 2012

I just saw an OOM from WikiEditor.i18n.php onncluster...

Status & tagging log