r111693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111692‎ | r111693 | r111694 >
Date:22:21, 16 February 2012
Author:bsitu
Status:ok (Comments)
Tags:
Comment:
followup to -r111692 - wrap long line
Modified paths:
  • /trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleCreationWorkflow/ArticleCreationWorkflow.hooks.php
——@@ -149,7 +149,8 @@
150150 if ( $res['source'] ) {
151151 $res['source'] .= '_';
152152 }
153 - ArticleCreationUtil::clickTracking( $res['bucket'] . '-' . 'create_' . $res['source'] . 'edit_success', $article->getTitle() );
 153+ ArticleCreationUtil::clickTracking( $res['bucket'] . '-' . 'create_' .
 154+ $res['source'] . 'edit_success', $article->getTitle() );
154155 }
155156
156157 return true;
——@@ -168,7 +169,8 @@
169170 if ( $res['source'] ) {
170171 $res['source'] .= '_';
171172 }
172 - ArticleCreationUtil::clickTracking( $res['bucket'] . '-' . 'create_' . $res['source'] . 'edit_attempt', $editpage->getArticle()->getTitle() );
 173+ ArticleCreationUtil::clickTracking( $res['bucket'] . '-' . 'create_' . $res['source'] .
 174+ 'edit_attempt', $editpage->getArticle()->getTitle() );
173175 }
174176
175177 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111692Standardizing clickTracking event name for article creation workflow by intro...bsitu22:17, 16 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:15, 17 February 2012

Why so much indentation on the second line?

#Comment by Bsitu (talk | contribs)   22:23, 17 February 2012

I want to keep function arguments as aligned as possible so it's easier to read

#Comment by Nikerabbit (talk | contribs)   09:22, 18 February 2012

We don't usually do that, but if you do you should use the same amount of tabs as the line above and do the rest with spaces. Anything else will not align properly for everyone at the same time, as you can see from above diff.

Status & tagging log