r111690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111689‎ | r111690 | r111691 >
Date:22:14, 16 February 2012
Author:reedy
Status:reverted (Comments)
Tags:gerritmigration, php5.3 
Comment:
Few more LSB for good measure
Modified paths:
  • /trunk/extensions/AntiSpoof/AntiSpoofHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AntiSpoof/AntiSpoofHooks.php
@@ -52,7 +52,7 @@
5353 }
5454
5555 $name = $user->getName();
56 - $spoof = self::makeSpoofUser( $name );
 56+ $spoof = static::makeSpoofUser( $name );
5757 if ( $spoof->isLegal() ) {
5858 $normalized = $spoof->getNormalized();
5959 $conflicts = $spoof->getConflicts();
@@ -108,7 +108,7 @@
109109 * @return bool
110110 */
111111 public static function asAddNewAccountHook( $user ) {
112 - $spoof = self::makeSpoofUser( $user->getName() );
 112+ $spoof = static::makeSpoofUser( $user->getName() );
113113 $spoof->record();
114114 return true;
115115 }
@@ -123,7 +123,7 @@
124124 * @return bool
125125 */
126126 public static function asAddRenameUserHook( $uid, $oldName, $newName ) {
127 - $spoof = self::makeSpoofUser( $newName );
 127+ $spoof = static::makeSpoofUser( $newName );
128128 $spoof->update( $oldName );
129129 return true;
130130 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r111691MFT r111688, r111690reedy22:17, 16 February 2012
r114392Revert r111688, r111690, r114156. Unreviewed revisions in AntiSpoof....catrope19:12, 21 March 2012

Comments

#Comment by Awjrichards (talk | contribs)   20:08, 17 February 2012

Returning to 'new' as this breaks compatibility with PHP < 5.3, pending a change in minimum PHP requirement.

#Comment by Hashar (talk | contribs)   14:43, 26 March 2012

This revision is now in Gerrit https://gerrit.wikimedia.org/r/3408

Status & tagging log