r111676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111675‎ | r111676 | r111677 >
Date:20:29, 16 February 2012
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 34445) section edit and TOC hide/show links are excluded from selection and copy/paste on supporting browsers

Tested on current Firefox, Chrome, Safari, Opera:
* Firefox excludes from select and copy
* Chrome, Safari exclude from select, but they turn up on the copy
* Opera doesn't seem to support the setting (event namespaced)
* IE not tested but 10 should support it if 9 doesn't
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.20 (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -1038,3 +1038,10 @@
10391039 position: absolute;
10401040 z-index: 99;
10411041 }
 1042+
 1043+.editsection, .toctoggle {
 1044+ -moz-user-select: none;
 1045+ -webkit-user-select: none;
 1046+ -ms-user-select: none;
 1047+ user-select: none;
 1048+}
Index: trunk/phase3/RELEASE-NOTES-1.20
——@@ -27,6 +27,8 @@
2828 * (bug 32210) New edit emails for watched pages always provide a link to the
2929 edit which triggered the mail.
3030 * (bug 12021) Added user talk link on Special:Listusers
 31+* (bug 34445) section edit and TOC hide/show links are excluded from selection and
 32+ copy/paste on supporting browsers
3133
3234 === API changes in 1.20 ===
3335 * (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.

Sign-offs

UserFlagDate
Nikerabbitinspected06:45, 17 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   06:45, 17 February 2012

Can we do the same to the line numbers in this new diff style? They make copying to comment are more work.

#Comment by Krinkle (talk | contribs)   05:32, 1 March 2012

The diffs does have the numbers in the same table row, however there is 1 table row for each diffed file's content (now 1 row per line in the diff). So you can select one ore more lines of diff text in CodeReview without selecting the diff columns, try it :) (Tested in Chrome and Firefox)

Status & tagging log