r111658 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111657‎ | r111658 | r111659 >
Date:18:22, 16 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Improve error log formatting and added error message info for InvalidResponseException
Modified paths:
  • /trunk/phase3/includes/filerepo/backend/SwiftFileBackend.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/backend/SwiftFileBackend.php
@@ -807,7 +807,11 @@
808808 */
809809 protected function logException( Exception $e, $func, array $params ) {
810810 wfDebugLog( 'SwiftBackend',
811 - get_class( $e ) . " in '{$this->name}': '{$func}' with " . serialize( $params )
 811+ get_class( $e ) . " in '{$func}' (given '" . serialize( $params ) . "')" .
 812+ ( $e instanceof InvalidResponseException
 813+ ? ": {$e->getMessage()}"
 814+ : ""
 815+ )
812816 );
813817 }
814818 }

Sign-offs

UserFlagDate
Nikerabbitinspected06:28, 17 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r111770MFT r111478, r111571, r111574, r111597, r111658reedy18:15, 17 February 2012
r112024MFT r111658, r111965, r111966, r111967, r112021reedy17:07, 21 February 2012

Status & tagging log