r111602 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111601‎ | r111602 | r111603 >
Date:00:35, 16 February 2012
Author:tstarling
Status:reverted
Tags:
Comment:
Temporary patch for bug 34428
Modified paths:
  • /branches/wmf/1.19wmf1/includes/HistoryBlob.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/HistoryBlob.php
@@ -520,7 +520,8 @@
521521 $ofp = mhash( MHASH_ADLER32, $base );
522522 if ( $ofp !== substr( $diff, 0, 4 ) ) {
523523 wfDebug( __METHOD__. ": incorrect base checksum\n" );
524 - return false;
 524+ // Temp patch for bug 34428: don't return false
 525+ //return false;
525526 }
526527 }
527528 if ( $header['csize'] != strlen( $base ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r111603Temp patch for bug 34428, merged from 1.19wmf1 r111602tstarling00:51, 16 February 2012
r111701(bug 34428) Fixed hash mismatch errors in DiffHistoryBlob::patch() by simulat...tstarling23:27, 16 February 2012

Status & tagging log