r111590 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111589‎ | r111590 | r111591 >
Date:22:42, 15 February 2012
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Improve table comments.
Modified paths:
  • /trunk/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tables.sql
@@ -159,7 +159,8 @@
160160 CREATE INDEX /*i*/ug_group ON /*_*/user_groups (ug_group);
161161
162162 -- Stores the groups the user has once belonged to.
 163+-- The user may still belong these groups (check user_groups).
 164+-- Users are not autopromoted to groups from which they were removed.
163165 CREATE TABLE /*_*/user_former_groups (
164166 -- Key to user_id
165167 ufg_user int unsigned NOT NULL default 0,
@@ -1439,7 +1440,7 @@
14401441 ) /*$wgDBTableOptions*/;
14411442 CREATE INDEX /*i*/lc_lang_key ON /*_*/l10n_cache (lc_lang, lc_key);
14421443
 1444+-- Table for caching JSON message blobs for the resource loader
14431445 CREATE TABLE /*_*/msg_resource (
14441446 -- Resource name
14451447 mr_resource varbinary(255) NOT NULL,
@@ -1460,8 +1461,8 @@
14611462 ) /*$wgDBTableOptions*/;
14621463 CREATE UNIQUE INDEX /*i*/mrl_message_resource ON /*_*/msg_resource_links (mrl_message, mrl_resource);
14631464
 1465+-- Table caching which local files a module depends on that aren't
 1466+-- registered directly, used for fast retrieval of file dependency.
14641467 -- Currently only used for tracking images that CSS depends on
14651468 CREATE TABLE /*_*/module_deps (
14661469 -- Module name

Follow-up revisions

RevisionCommit summaryAuthorDate
r111686Fix r111590 typo.platonides21:32, 16 February 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   00:55, 16 February 2012

Should be 'belong to these groups'.

#Comment by Platonides (talk | contribs)   21:33, 16 February 2012

Thanks. Fixed in r111686.

I had to read them three times to spot the difference :)

Status & tagging log