r111475 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111474‎ | r111475 | r111476 >
Date:19:57, 14 February 2012
Author:jpostlethwaite
Status:resolved (Comments)
Tags:
Comment:
Updating english messages to use PLURAL for LastModified extension. See r99522.
Modified paths:
  • /trunk/extensions/LastModified/LastModified.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LastModified/LastModified.i18n.php
——@@ -39,12 +39,12 @@
4040 'lastmodified-display' => 'Display:',
4141 'lastmodified-display-range-value' => 'Display range value:',
4242 'lastmodified-title-tag' => 'View the revision history for this page.',
43 - 'lastmodified-seconds' => 'Last updated $1 seconds ago',
44 - 'lastmodified-minutes' => 'Last updated $1 minutes ago',
45 - 'lastmodified-hours' => 'Last updated $1 hours ago',
46 - 'lastmodified-days' => 'Last updated $1 days ago',
47 - 'lastmodified-months' => 'Last updated $1 months ago',
48 - 'lastmodified-years' => 'Last updated $1 years ago',
 43+ 'lastmodified-seconds' => 'Last updated {{PLURAL:$1|$1 second|$1 seconds}} ago',
 44+ 'lastmodified-minutes' => 'Last updated {{PLURAL:$1|$1 minute|$1 minutes}} ago',
 45+ 'lastmodified-hours' => 'Last updated {{PLURAL:$1|$1 hour|$1 hours}} ago',
 46+ 'lastmodified-days' => 'Last updated {{PLURAL:$1|$1 day|$1 days}} ago',
 47+ 'lastmodified-months' => 'Last updated {{PLURAL:$1|$1 month|$1 months}} ago',
 48+ 'lastmodified-years' => 'Last updated {{PLURAL:$1|$1 year|$1 years}} ago',
4949 );
5050
5151 /** Message documentation (Message documentation)

Follow-up revisions

RevisionCommit summaryAuthorDate
r113748Fixed r111475. Added dependency on mediawiki.jqueryMsg.jpostlethwaite19:03, 13 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99522Adding new extension LastModified.jpostlethwaite18:30, 11 October 2011

Comments

#Comment by Jpostlethwaite (talk | contribs)   20:02, 14 February 2012

PLURAL still does not seem to be fully functional in javascript.

I am getting this output to pages: 

Last updated {{PLURAL:23|23 day|23 days}} ago
#Comment by Siebrand (talk | contribs)   14:51, 15 February 2012

You may be missing a JS dependency, and possibly need to use another method so that the magic words are processed.

#Comment by Catrope (talk | contribs)   18:47, 13 March 2012

This should just work if you add a dependency on mediawiki.jqueryMsg

#Comment by Jpostlethwaite (talk | contribs)   19:04, 13 March 2012

Thanks!

That fixed the problem. See r113748.

Status & tagging log