r111434 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111433‎ | r111434 | r111435 >
Date:23:31, 13 February 2012
Author:werdna
Status:ok
Tags:acw-deploy 
Comment:
Return jqXHR objects
Modified paths:
  • /trunk/extensions/ClickTracking/modules/jquery.clickTracking.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ClickTracking/modules/jquery.clickTracking.js
@@ -25,7 +25,7 @@
2626 * @param {string} id event identifier
2727 */
2828 $.trackAction = function( id ) {
29 - $.trackActionWithOptions( { 'id' : id });
 29+ return $.trackActionWithOptions( { 'id' : id });
3030 };
3131 /**
3232 * Performs click tracking API call
@@ -34,7 +34,7 @@
3535 * @param {string} info additional information to be stored with the click
3636 */
3737 $.trackActionWithInfo = function( id, info ) {
38 - $.trackActionWithOptions( { 'id' : id, 'info' : info });
 38+ return $.trackActionWithOptions( { 'id' : id, 'info' : info });
3939 };
4040
4141 /**
@@ -67,7 +67,7 @@
6868 data.additional = options.info;
6969 }
7070
71 - $.post( mw.util.wikiScript( 'api' ), data);
 71+ return $.post( mw.util.wikiScript( 'api' ), data);
7272 };
7373
7474 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r111435Doc for r111434werdna23:32, 13 February 2012

Status & tagging log