r111414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111413‎ | r111414 | r111415 >
Date:20:27, 13 February 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Merge SQL files, not much reason to be separate, they're not automagically used
Modified paths:
  • /trunk/extensions/GlobalBlocking/globalblocking.sql (modified) (history)
  • /trunk/extensions/GlobalBlocking/localdb_patches (deleted) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/globalblocking.sql
——@@ -18,3 +18,14 @@
1919 INDEX gb_timestamp (gb_timestamp),
2020 INDEX gb_expiry (gb_expiry)
2121 ) /*$wgDBTableOptions*/;
 22+
 23+CREATE TABLE /*$wgDBprefix*/global_block_whitelist (
 24+ gbw_id int(11) NOT NULL, -- Key to gb_id in globalblocks database.
 25+ gbw_address varbinary(255) NOT NULL,
 26+ gbw_by int(11) NOT NULL, -- Key to user_id
 27+ gbw_by_text varchar(255) NOT NULL,
 28+ gbw_reason varchar(255) NOT NULL,
 29+ gbw_expiry binary(14) NOT NULL,
 30+ PRIMARY KEY (gbw_id),
 31+ KEY (gbw_by)
 32+) /*$wgDBTableOptions*/;

Comments

#Comment by Aaron Schulz (talk | contribs)   00:30, 17 February 2012

One is for a global table and one is not. I guess one could copy on the parts that matter, but I preferred two different files.

Status & tagging log