r111397 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111396‎ | r111397 | r111398 >
Date:18:42, 13 February 2012
Author:ialex
Status:ok
Tags:
Comment:
* (bug 34377) action=watch now parses messages using the correct title instead of "API"
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiWatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -281,6 +281,8 @@
282282 values is given as an array.
283283 * (bug 32948) {{REVISIONID}} and related variables are no longer blank after
284284 calling action=purge&forcelinkupdate.
 285+* (bug 34377) action=watch now parses messages using the correct title instead
 286+ of "API".
285287
286288 === Languages updated in 1.19 ===
287289
Index: trunk/phase3/includes/api/ApiWatch.php
@@ -52,11 +52,11 @@
5353
5454 if ( $params['unwatch'] ) {
5555 $res['unwatched'] = '';
56 - $res['message'] = wfMsgExt( 'removedwatchtext', array( 'parse' ), $title->getPrefixedText() );
 56+ $res['message'] = $this->msg( 'removedwatchtext', $title->getPrefixedText() )->title( $title )->parseAsBlock();
5757 $success = UnwatchAction::doUnwatch( $title, $user );
5858 } else {
5959 $res['watched'] = '';
60 - $res['message'] = wfMsgExt( 'addedwatchtext', array( 'parse' ), $title->getPrefixedText() );
 60+ $res['message'] = $this->msg( 'addedwatchtext', $title->getPrefixedText() )->title( $title )->parseAsBlock();
6161 $success = WatchAction::doWatch( $title, $user );
6262 }
6363 if ( !$success ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r111398* (bug 34377) action=watch now parses messages using the correct title instea...ialex18:53, 13 February 2012
r111422MFT r111397reedy21:29, 13 February 2012

Status & tagging log