r111224 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r111223‎ | r111224 | r111225 >
Date:01:33, 11 February 2012
Author:mah
Status:ok (Comments)
Tags:
Comment:
w/s
Modified paths:
  • /trunk/phase3/includes/Action.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Action.php
——@@ -128,7 +128,7 @@
129129 if ( !$context->canUseWikiPage() ) {
130130 return 'view';
131131 }
132 -
 132+
133133 $action = Action::factory( $actionName, $context->getWikiPage() );
134134 if ( $action instanceof Action ) {
135135 return $action->getName();

Comments

#Comment by RobLa-WMF (talk | contribs)   06:27, 11 February 2012

Mark, please see Aaron's comment from r111224. Basically, he's pointing out (albeit tersely) that making whitespace changes like this now makes it more likely that we'll have merge conflicts when we backport fixes into 1.19. We'll need to do that quite a bit over the coming days as we make last minute fixes. So please, don't do this. Thanks.

#Comment by RobLa-WMF (talk | contribs)   06:29, 11 February 2012

Er, make that "Aaron's comment from r111221"

Status & tagging log