r11111 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11110‎ | r11111 | r11112 >
Date:03:47, 24 September 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 3182) Clear link cache during import to prevent memory leak
Modified paths:
  • /branches/REL1_5/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_5/phase3/includes/SpecialImport.php (modified) (history)
  • /branches/REL1_5/phase3/maintenance/importDump.php (modified) (history)

Diff [purge]

Index: branches/REL1_5/phase3/maintenance/importDump.php
@@ -45,6 +45,7 @@
4646 function handleRevision( $rev ) {
4747 $title = $rev->getTitle();
4848 if (!$title) {
 49+ $this->progress( "Got bogus revision with null title!" );
4950 return;
5051 }
5152 $display = $title->getPrefixedText();
Index: branches/REL1_5/phase3/includes/SpecialImport.php
@@ -197,6 +197,10 @@
198198 $userText = $this->getUser();
199199 }
200200
 201+ // avoid memory leak...?
 202+ global $wgLinkCache;
 203+ $wgLinkCache->clear();
 204+
201205 $article = new Article( $this->title );
202206 $pageId = $article->getId();
203207 if( $pageId == 0 ) {
Index: branches/REL1_5/phase3/RELEASE-NOTES
@@ -772,6 +772,7 @@
773773 * (bug 3350) Missing label for move talk page checkbox.
774774 * (bug 2570) Add 'watch this page' checkbox on uploads, watch uploads
775775 by default when 'watchdefault' option is on
 776+* (bug 3182) Clear link cache during import to prevent memory leak
776777
777778
778779 === Caveats ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r11110* (bug 3182) Clear link cache during import to prevent memory leakvibber03:44, 24 September 2005

Status & tagging log