r11110 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r11109‎ | r11110 | r11111 >
Date:03:44, 24 September 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 3182) Clear link cache during import to prevent memory leak
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialImport.php (modified) (history)
  • /trunk/phase3/maintenance/importDump.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/importDump.php
@@ -45,6 +45,7 @@
4646 function handleRevision( $rev ) {
4747 $title = $rev->getTitle();
4848 if (!$title) {
 49+ $this->progress( "Got bogus revision with null title!" );
4950 return;
5051 }
5152 $display = $title->getPrefixedText();
Index: trunk/phase3/includes/SpecialImport.php
@@ -197,6 +197,10 @@
198198 $userText = $this->getUser();
199199 }
200200
 201+ // avoid memory leak...?
 202+ global $wgLinkCache;
 203+ $wgLinkCache->clear();
 204+
201205 $article = new Article( $this->title );
202206 $pageId = $article->getId();
203207 if( $pageId == 0 ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -118,6 +118,7 @@
119119 by default when 'watchdefault' option is on
120120 * Skip update of disused 'rc_cur_time' field (todo: discard the field)
121121 * (bug 3506) Avoid MySQL error when Listusers returns no results
 122+* (bug 3182) Clear link cache during import to prevent memory leak
122123
123124
124125 === Caveats ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r11111* (bug 3182) Clear link cache during import to prevent memory leakvibber03:47, 24 September 2005

Status & tagging log