r111073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111072‎ | r111073 | r111074 >
Date:19:30, 9 February 2012
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Fixing some of the "@return true" or "@return false", need to be "@return bool" and then the metadata can say true if foo, false if bar

Other documentation improvements
Modified paths:
  • /trunk/phase3/includes/ChangesFeed.php (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/includes/Collation.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/FormOptions.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)
  • /trunk/phase3/includes/Hooks.php (modified) (history)
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)
  • /trunk/phase3/includes/Import.php (modified) (history)
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /trunk/phase3/includes/cache/MessageCache.php (modified) (history)
  • /trunk/phase3/includes/db/Database.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseIbm_db2.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMysql.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)
  • /trunk/phase3/includes/diff/DairikiDiff.php (modified) (history)
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)
  • /trunk/phase3/includes/filerepo/RepoGroup.php (modified) (history)
  • /trunk/phase3/includes/filerepo/file/File.php (modified) (history)
  • /trunk/phase3/includes/filerepo/file/LocalFile.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)
  • /trunk/phase3/includes/libs/CSSJanus.php (modified) (history)
  • /trunk/phase3/includes/libs/IEUrlExtension.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -2182,7 +2182,7 @@
21832183 * The $textoverride method can be used by subclasses overriding showContentForm
21842184 * to pass back to this method.
21852185 *
2186 - * @param $customAttribs An array of html attributes to use in the textarea
 2186+ * @param $customAttribs array of html attributes to use in the textarea
21872187 * @param $textoverride String: optional text to override $this->textarea1 with
21882188 */
21892189 protected function showTextbox1( $customAttribs = null, $textoverride = null ) {
@@ -2817,7 +2817,7 @@
28182818 * Returns an array of html code of the following checkboxes:
28192819 * minor and watch
28202820 *
2821 - * @param $tabindex Current tabindex
 2821+ * @param $tabindex int Current tabindex
28222822 * @param $checked Array of checkbox => bool, where bool indicates the checked
28232823 * status of the checkbox
28242824 *
@@ -2868,7 +2868,7 @@
28692869 * Returns an array of html code of the following buttons:
28702870 * save, diff, preview and live
28712871 *
2872 - * @param $tabindex Current tabindex
 2872+ * @param $tabindex int Current tabindex
28732873 *
28742874 * @return array
28752875 */
@@ -2997,7 +2997,7 @@
29982998 /**
29992999 * Produce the stock "your edit contains spam" page
30003000 *
3001 - * @param $match Text which triggered one or more filters
 3001+ * @param $match string Text which triggered one or more filters
30023002 * @deprecated since 1.17 Use method spamPageWithContent() instead
30033003 */
30043004 static function spamPage( $match = false ) {
@@ -3020,7 +3020,7 @@
30213021 /**
30223022 * Show "your edit contains spam" page with your diff and text
30233023 *
3024 - * @param $match Text which triggered one or more filters
 3024+ * @param $match string|bool Text which triggered one or more filters
30253025 */
30263026 public function spamPageWithContent( $match = false ) {
30273027 global $wgOut;
Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
@@ -304,7 +304,7 @@
305305 * Extracts from a single sql row the data needed to describe one recent change.
306306 *
307307 * @param $row The row from which to extract the data.
308 - * @return An array mapping strings (descriptors) to their respective string values.
 308+ * @return array An array mapping strings (descriptors) to their respective string values.
309309 * @access public
310310 */
311311 public function extractRowInfo( $row ) {
Index: trunk/phase3/includes/api/ApiDelete.php
@@ -145,7 +145,7 @@
146146 * @param $oldimage
147147 * @param $reason
148148 * @param $suppress bool
149 - * @return \type|array|Title
 149+ * @return array|Title
150150 */
151151 public static function deleteFile( Page $page, User $user, $token, $oldimage, &$reason = null, $suppress = false ) {
152152 $title = $page->getTitle();
Index: trunk/phase3/includes/HTMLForm.php
@@ -664,7 +664,7 @@
665665
666666 /**
667667 * Get the text for the submit button, either customised or a default.
668 - * @return unknown_type
 668+ * @return
669669 */
670670 function getSubmitText() {
671671 return $this->mSubmitText
@@ -852,7 +852,7 @@
853853 * to the form as a whole, after it's submitted but before it's
854854 * processed.
855855 * @param $data
856 - * @return unknown_type
 856+ * @return
857857 */
858858 function filterDataForSubmit( $data ) {
859859 return $data;
Index: trunk/phase3/includes/ImageGallery.php
@@ -75,7 +75,7 @@
7676 /**
7777 * Set the caption (as plain text)
7878 *
79 - * @param $caption Caption
 79+ * @param $caption string Caption
8080 */
8181 function setCaption( $caption ) {
8282 $this->mCaption = htmlspecialchars( $caption );
Index: trunk/phase3/includes/FormOptions.php
@@ -65,7 +65,7 @@
6666 *
6767 * @param $data Mixed: value to guess type for
6868 * @exception MWException Unsupported datatype
69 - * @return Type constant
 69+ * @return int Type constant
7070 */
7171 public static function guessType( $data ) {
7272 if ( is_bool( $data ) ) {
Index: trunk/phase3/includes/Import.php
@@ -301,7 +301,8 @@
302302
303303 /**
304304 * Notify the callback function of a revision
305 - * @param $revision A WikiRevision object
 305+ * @param $revision |WikiRevision object
 306+ * @return bool|mixed
306307 */
307308 private function revisionCallback( $revision ) {
308309 if ( isset( $this->mRevisionCallback ) ) {
@@ -314,7 +315,8 @@
315316
316317 /**
317318 * Notify the callback function of a new log item
318 - * @param $revision A WikiRevision object
 319+ * @param $revision WikiRevision object
 320+ * @return bool|mixed
319321 */
320322 private function logItemCallback( $revision ) {
321323 if ( isset( $this->mLogItemCallback ) ) {
Index: trunk/phase3/includes/libs/CSSJanus.php
@@ -122,7 +122,7 @@
123123 * @param $css String: stylesheet to transform
124124 * @param $swapLtrRtlInURL Boolean: If true, swap 'ltr' and 'rtl' in URLs
125125 * @param $swapLeftRightInURL Boolean: If true, swap 'left' and 'right' in URLs
126 - * @return Transformed stylesheet
 126+ * @return string Transformed stylesheet
127127 */
128128 public static function transform( $css, $swapLtrRtlInURL = false, $swapLeftRightInURL = false ) {
129129 // We wrap tokens in ` , not ~ like the original implementation does.
Index: trunk/phase3/includes/libs/IEUrlExtension.php
@@ -73,7 +73,7 @@
7474 * a potentially harmful file extension.
7575 *
7676 * @param $urlPart string The right-hand portion of a URL
77 - * @param $extWhitelist An array of file extensions which may occur in this
 77+ * @param $extWhitelist array An array of file extensions which may occur in this
7878 * URL, and which should be allowed.
7979 * @return bool
8080 */
Index: trunk/phase3/includes/cache/MessageCache.php
@@ -588,7 +588,7 @@
589589 * @param $isFullKey Boolean: specifies whether $key is a two part key
590590 * "msg/lang".
591591 *
592 - * @return string|false
 592+ * @return string|bool
593593 */
594594 function get( $key, $useDB = true, $langcode = true, $isFullKey = false ) {
595595 global $wgLanguageCode, $wgContLang;
Index: trunk/phase3/includes/Collation.php
@@ -311,7 +311,7 @@
312312 * -1, 0 or 1 in the style of strcmp().
313313 * @param $target string The target value to find.
314314 *
315 - * @return The item index of the lower bound, or false if the target value
 315+ * @return int|bool The item index of the lower bound, or false if the target value
316316 * sorts before all items.
317317 */
318318 function findLowerBound( $valueCallback, $valueCount, $comparisonCallback, $target ) {
Index: trunk/phase3/includes/ChangesFeed.php
@@ -107,7 +107,7 @@
108108 * @param $lastmod Integer: timestamp of the last item in the recentchanges table
109109 * @param $timekey String: memcached key of the last modification
110110 * @param $key String: memcached key of the content
111 - * @return feed's content on cache hit or false on cache miss
 111+ * @return string|bool feed's content on cache hit or false on cache miss
112112 */
113113 public function loadFromCache( $lastmod, $timekey, $key ) {
114114 global $wgFeedCacheTimeout, $wgOut, $messageMemc;
Index: trunk/phase3/includes/filerepo/RepoGroup.php
@@ -213,7 +213,7 @@
214214 * Returns false if the file does not exist.
215215 *
216216 * @param $hash String base 36 SHA-1 hash
217 - * @param $options Option array, same as findFile()
 217+ * @param $options array Option array, same as findFile()
218218 * @return File object or false if it is not found
219219 */
220220 function findFileFromKey( $hash, $options = array() ) {
@@ -339,7 +339,8 @@
340340
341341 /**
342342 * Split a virtual URL into repo, zone and rel parts
343 - * @return an array containing repo, zone and rel
 343+ * @param $url string
 344+ * @return array containing repo, zone and rel
344345 */
345346 function splitVirtualUrl( $url ) {
346347 if ( substr( $url, 0, 9 ) != 'mwrepo://' ) {
Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -344,7 +344,7 @@
345345 /**
346346 * Find many files at once.
347347 *
348 - * @param $items An array of titles, or an array of findFile() options with
 348+ * @param $items array An array of titles, or an array of findFile() options with
349349 * the "title" option giving the title. Example:
350350 *
351351 * $findItem = array( 'title' => $title, 'private' => true );
@@ -996,7 +996,7 @@
997997 /**
998998 * Checks existence of a a file
999999 *
1000 - * @param $file Virtual URL (or storage path) of file to check
 1000+ * @param $file string Virtual URL (or storage path) of file to check
10011001 * @param $flags Integer: bitwise combination of the following flags:
10021002 * self::FILES_ONLY Mark file as existing only if it is a file (not directory)
10031003 * @return bool
@@ -1012,7 +1012,7 @@
10131013 * @param $files Array: Virtual URLs (or storage paths) of files to check
10141014 * @param $flags Integer: bitwise combination of the following flags:
10151015 * self::FILES_ONLY Mark file as existing only if it is a file (not directory)
1016 - * @return Either array of files and existence flags, or false
 1016+ * @return array|bool Either array of files and existence flags, or false
10171017 */
10181018 public function fileExistsBatch( $files, $flags = 0 ) {
10191019 $result = array();
Index: trunk/phase3/includes/filerepo/file/LocalFile.php
@@ -1301,7 +1301,7 @@
13021302 *
13031303 * May throw database exceptions on error.
13041304 *
1305 - * @param $versions set of record ids of deleted items to restore,
 1305+ * @param $versions array set of record ids of deleted items to restore,
13061306 * or empty to restore all revisions.
13071307 * @param $unsuppress Boolean
13081308 * @return FileRepoStatus
Index: trunk/phase3/includes/filerepo/file/File.php
@@ -987,8 +987,8 @@
988988 *
989989 * STUB
990990 * @param $limit integer Limit of rows to return
991 - * @param $start timestamp Only revisions older than $start will be returned
992 - * @param $end timestamp Only revisions newer than $end will be returned
 991+ * @param $start string timestamp Only revisions older than $start will be returned
 992+ * @param $end string timestamp Only revisions newer than $end will be returned
993993 * @param $inc bool Include the endpoints of the time range
994994 *
995995 * @return array
@@ -1185,7 +1185,7 @@
11861186 *
11871187 * @param $suffix bool|string if not false, the name of a thumbnail file
11881188 *
1189 - * @return path
 1189+ * @return string path
11901190 */
11911191 function getThumbUrl( $suffix = false ) {
11921192 $this->assertRepoDefined();
Index: trunk/phase3/includes/ChangesList.php
@@ -63,7 +63,7 @@
6464 * This first argument used to be an User object.
6565 *
6666 * @deprecated in 1.18; use newFromContext() instead
67 - * @param $unused Unused
 67+ * @param $unused
6868 * @return ChangesList|EnhancedChangesList|OldChangesList derivative
6969 */
7070 public static function newFromUser( $unused ) {
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -1768,7 +1768,7 @@
17691769 * Return a string consisting of callers in the stack. Useful sometimes
17701770 * for profiling specific points.
17711771 *
1772 - * @param $limit The maximum depth of the stack frame to return, or false for
 1772+ * @param $limit int The maximum depth of the stack frame to return, or false for
17731773 * the entire stack.
17741774 * @return String
17751775 */
@@ -1977,7 +1977,7 @@
19781978 * A wrapper around the PHP function var_export().
19791979 * Either print it or add it to the regular output ($wgOut).
19801980 *
1981 - * @param $var A PHP variable to dump.
 1981+ * @param $var mixed A PHP variable to dump.
19821982 */
19831983 function wfVarDump( $var ) {
19841984 global $wgOut;
@@ -2749,11 +2749,11 @@
27502750 * Execute a shell command, with time and memory limits mirrored from the PHP
27512751 * configuration if supported.
27522752 * @param $cmd String Command line, properly escaped for shell.
2753 - * @param &$retval optional, will receive the program's exit code.
 2753+ * @param &$retval null|Mixed optional, will receive the program's exit code.
27542754 * (non-zero is usually failure)
27552755 * @param $environ Array optional environment variables which should be
27562756 * added to the executed command environment.
2757 - * @return collected stdout as a string (trailing newlines stripped)
 2757+ * @return string collected stdout as a string (trailing newlines stripped)
27582758 */
27592759 function wfShellExec( $cmd, &$retval = null, $environ = array() ) {
27602760 global $IP, $wgMaxShellMemory, $wgMaxShellFileSize, $wgMaxShellTime;
@@ -3513,7 +3513,7 @@
35143514 /**
35153515 * Get the script URL.
35163516 *
3517 - * @return script URL
 3517+ * @return string script URL
35183518 */
35193519 function wfGetScriptUrl() {
35203520 if( isset( $_SERVER['SCRIPT_NAME'] ) ) {
Index: trunk/phase3/includes/db/DatabaseMysql.php
@@ -860,7 +860,7 @@
861861 /**
862862 * List all tables on the database
863863 *
864 - * @param $prefix Only show tables with this prefix, e.g. mw_
 864+ * @param $prefix string Only show tables with this prefix, e.g. mw_
865865 * @param $fname String: calling function name
866866 * @return array
867867 */
Index: trunk/phase3/includes/db/DatabaseIbm_db2.php
@@ -667,7 +667,7 @@
668668 * Fields can be retrieved with $row->fieldname, with fields acting like
669669 * member variables.
670670 *
671 - * @param $res SQL result object as returned from Database::query(), etc.
 671+ * @param $res array|ResultWrapper SQL result object as returned from Database::query(), etc.
672672 * @return DB2 row object
673673 * @throws DBUnexpectedError Thrown if the database returns an error
674674 */
@@ -689,8 +689,8 @@
690690 * Fetch the next row from the given result object, in associative array
691691 * form. Fields are retrieved with $row['fieldname'].
692692 *
693 - * @param $res SQL result object as returned from Database::query(), etc.
694 - * @return DB2 row object
 693+ * @param $res array|ResultWrapper SQL result object as returned from Database::query(), etc.
 694+ * @return ResultWrapper row object
695695 * @throws DBUnexpectedError Thrown if the database returns an error
696696 */
697697 public function fetchRow( $res ) {
@@ -715,7 +715,7 @@
716716 * Doesn't escape numbers
717717 *
718718 * @param $s String: string to escape
719 - * @return escaped string
 719+ * @return string escaped string
720720 */
721721 public function addQuotes( $s ) {
722722 //$this->installPrint( "DB2::addQuotes( $s )\n" );
@@ -758,7 +758,7 @@
759759 /**
760760 * Alias for addQuotes()
761761 * @param $s String: string to escape
762 - * @return escaped string
 762+ * @return string escaped string
763763 */
764764 public function strencode( $s ) {
765765 // Bloody useless function
@@ -904,7 +904,7 @@
905905 /**
906906 * Generates a timestamp in an insertable format
907907 *
908 - * @param $ts timestamp
 908+ * @param $ts string timestamp
909909 * @return String: timestamp value
910910 */
911911 public function timestamp( $ts = 0 ) {
@@ -915,7 +915,7 @@
916916 /**
917917 * Return the next in a sequence, save the value for retrieval via insertId()
918918 * @param $seqName String: name of a defined sequence in the database
919 - * @return next value in that sequence
 919+ * @return int next value in that sequence
920920 */
921921 public function nextSequenceValue( $seqName ) {
922922 // Not using sequences in the primary schema to allow for easier migration
@@ -934,7 +934,7 @@
935935
936936 /**
937937 * This must be called after nextSequenceVal
938 - * @return Last sequence value used as a primary key
 938+ * @return int Last sequence value used as a primary key
939939 */
940940 public function insertId() {
941941 return $this->mInsertId;
@@ -1121,11 +1121,11 @@
11221122 * UPDATE wrapper, takes a condition array and a SET array
11231123 *
11241124 * @param $table String: The table to UPDATE
1125 - * @param $values An array of values to SET
1126 - * @param $conds An array of conditions ( WHERE ). Use '*' to update all rows.
 1125+ * @param $values array An array of values to SET
 1126+ * @param $conds array An array of conditions ( WHERE ). Use '*' to update all rows.
11271127 * @param $fname String: The Class::Function calling this function
11281128 * ( for the log )
1129 - * @param $options An array of UPDATE options, can be one or
 1129+ * @param $options array An array of UPDATE options, can be one or
11301130 * more of IGNORE, LOW_PRIORITY
11311131 * @return Boolean
11321132 */
@@ -1206,7 +1206,7 @@
12071207 * Moves the row pointer of the result set
12081208 * @param $res Object: result set
12091209 * @param $row Integer: row number
1210 - * @return success or failure
 1210+ * @return bool success or failure
12111211 */
12121212 public function dataSeek( $res, $row ) {
12131213 if ( $res instanceof ResultWrapper ) {
@@ -1502,7 +1502,7 @@
15031503 * Verifies that an index was created as unique
15041504 * @param $table String: table name
15051505 * @param $index String: index name
1506 - * @param $fname function name for profiling
 1506+ * @param $fname string function name for profiling
15071507 * @return Bool
15081508 */
15091509 public function indexUnique ( $table, $index,
Index: trunk/phase3/includes/db/Database.php
@@ -253,7 +253,7 @@
254254 * - false to disable debugging
255255 * - omitted or null to do nothing
256256 *
257 - * @return The previous value of the flag
 257+ * @return bool|null previous value of the flag
258258 */
259259 function debug( $debug = null ) {
260260 return wfSetBit( $this->mFlags, DBO_DEBUG, $debug );
@@ -279,7 +279,7 @@
280280 *
281281 * @param $buffer null|bool
282282 *
283 - * @return The previous value of the flag
 283+ * @return null|bool The previous value of the flag
284284 */
285285 function bufferResults( $buffer = null ) {
286286 if ( is_null( $buffer ) ) {
@@ -310,8 +310,8 @@
311311 * Historically, transactions were allowed to be "nested". This is no
312312 * longer supported, so this function really only returns a boolean.
313313 *
314 - * @param $level An integer (0 or 1), or omitted to leave it unchanged.
315 - * @return The previous value
 314+ * @param $level int An integer (0 or 1), or omitted to leave it unchanged.
 315+ * @return int The previous value
316316 */
317317 function trxLevel( $level = null ) {
318318 return wfSetVar( $this->mTrxLevel, $level );
@@ -319,8 +319,8 @@
320320
321321 /**
322322 * Get/set the number of errors logged. Only useful when errors are ignored
323 - * @param $count The count to set, or omitted to leave it unchanged.
324 - * @return The error count
 323+ * @param $count int The count to set, or omitted to leave it unchanged.
 324+ * @return int The error count
325325 */
326326 function errorCount( $count = null ) {
327327 return wfSetVar( $this->mErrorCount, $count );
@@ -328,8 +328,8 @@
329329
330330 /**
331331 * Get/set the table prefix.
332 - * @param $prefix The table prefix to set, or omitted to leave it unchanged.
333 - * @return The previous table prefix.
 332+ * @param $prefix string The table prefix to set, or omitted to leave it unchanged.
 333+ * @return string The previous table prefix.
334334 */
335335 function tablePrefix( $prefix = null ) {
336336 return wfSetVar( $this->mTablePrefix, $prefix );
@@ -1371,7 +1371,7 @@
13721372 * @param $options string|array Query options
13731373 * @param $join_conds string|array Join conditions
13741374 *
1375 - * @return SQL query string.
 1375+ * @return string SQL query string.
13761376 * @see DatabaseBase::select()
13771377 */
13781378 function selectSQLText( $table, $vars, $conds = '', $fname = 'DatabaseBase::select', $options = array(), $join_conds = array() ) {
@@ -2789,7 +2789,7 @@
27902790 * @param $timeout Integer: the maximum number of seconds to wait for
27912791 * synchronisation
27922792 *
2793 - * @return An integer: zero if the slave was past that position already,
 2793+ * @return integer: zero if the slave was past that position already,
27942794 * greater than zero if we waited for some period of time, less than
27952795 * zero if we timed out.
27962796 */
@@ -2909,7 +2909,7 @@
29102910 /**
29112911 * List all tables on the database
29122912 *
2913 - * @param $prefix Only show tables with this prefix, e.g. mw_
 2913+ * @param $prefix string Only show tables with this prefix, e.g. mw_
29142914 * @param $fname String: calling function name
29152915 */
29162916 function listTables( $prefix = null, $fname = 'DatabaseBase::listTables' ) {
@@ -3351,7 +3351,7 @@
33523352 * @param $lockName String: Name of lock to release
33533353 * @param $method String: Name of method calling us
33543354 *
3355 - * @return Returns 1 if the lock was released, 0 if the lock was not established
 3355+ * @return int Returns 1 if the lock was released, 0 if the lock was not established
33563356 * by this thread (in which case the lock is not released), and NULL if the named
33573357 * lock did not exist
33583358 */
Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -817,7 +817,7 @@
818818 /**
819819 * List all tables on the database
820820 *
821 - * @param $prefix Only show tables with this prefix, e.g. mw_
 821+ * @param $prefix string Only show tables with this prefix, e.g. mw_
822822 * @param $fname String: calling function name
823823 *
824824 * @return array
Index: trunk/phase3/includes/installer/SqliteInstaller.php
@@ -207,7 +207,7 @@
208208 }
209209
210210 /**
211 - * @return Staus
 211+ * @return Status
212212 */
213213 public function createTables() {
214214 $status = parent::createTables();
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -341,7 +341,7 @@
342342
343343 /**
344344 * Initiate an upgrade of the existing database
345 - * @param $vars Variables from LocalSettings.php and AdminSettings.php
 345+ * @param $vars array Variables from LocalSettings.php and AdminSettings.php
346346 * @return Status
347347 */
348348 protected function handleExistingUpgrade( $vars ) {
Index: trunk/phase3/includes/diff/DairikiDiff.php
@@ -661,7 +661,7 @@
662662 *
663663 * $diff = new Diff($lines1, $lines2);
664664 * $rev = $diff->reverse();
665 - * @return object A Diff object representing the inverse of the
 665+ * @return object object A Diff object representing the inverse of the
666666 * original diff.
667667 */
668668 function reverse() {
Index: trunk/phase3/includes/Hooks.php
@@ -259,7 +259,7 @@
260260 /**
261261 * This REALLY should be protected... but it's public for compatibility
262262 *
263 - * @param $errno Unused
 263+ * @param $errno
264264 * @param $errstr String: error message
265265 * @return Boolean: false
266266 */

Comments

#Comment by Nikerabbit (talk | contribs)   08:45, 10 February 2012
-	 * @param $errno Unused
+	 * @param $errno

Why?

#Comment by Reedy (talk | contribs)   15:13, 10 February 2012

Unused isn't a valid type

#Comment by Nikerabbit (talk | contribs)   19:38, 10 February 2012

Imho you are not looking the big picture while pursuing syntactic correctness.

Status & tagging log