r111024 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111023‎ | r111024 | r111025 >
Date:10:42, 9 February 2012
Author:catrope
Status:reverted
Tags:
Comment:
Explanatory comment for r111023
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2681,6 +2681,8 @@
26822682 );
26832683
26842684 // Load embeddable private modules before any loader links
 2685+ // Per bug 34289, this needs to be TYPE_SCRIPTS. Using TYPE_COMBINED
 2686+ // causes the user.options CSS to be loaded twice.
26852687 $embedScripts = array( 'user.options', 'user.tokens' );
26862688 $scripts .= $this->makeResourceLoaderLink( $embedScripts, ResourceLoaderModule::TYPE_SCRIPTS );
26872689

Follow-up revisions

RevisionCommit summaryAuthorDate
r111027Revert r111023 and r111024, they broke user.options . I'll fix this properly ...catrope10:59, 9 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111023(bug 34289) user.options CSS loaded twice. Caused by r107534. Made embedded p...catrope10:36, 9 February 2012

Status & tagging log